Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1760143003: bindings: Remove the hidden prototype from HTMLDocument. (Closed)

Created:
4 years, 9 months ago by Yuki
Modified:
4 years, 9 months ago
Reviewers:
haraken, peria
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bindings: Remove the hidden prototype from HTMLDocument. We no longer have a reason to hold it. Nothing depends on the "shadow" document. Removes the "shadow" document, which is making HTMLDocument a hidden prototype. BUG=591897 Committed: https://crrev.com/0fb38d20480525c24720b73aaca3845dba98082c Cr-Commit-Position: refs/heads/master@{#379519}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -35 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp View 1 2 3 chunks +0 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface_base.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Yuki
Could you review this CL? It seems that no test fails.
4 years, 9 months ago (2016-03-04 15:00:49 UTC) #3
haraken
Exciting change! LGTM. peria-san: Would you remeasure the performance of WindowProxy::initialize after this CL is ...
4 years, 9 months ago (2016-03-04 15:52:40 UTC) #5
peria
On 2016/03/04 15:52:40, haraken wrote: > Exciting change! LGTM. > > peria-san: Would you remeasure ...
4 years, 9 months ago (2016-03-07 02:04:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760143003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760143003/40001
4 years, 9 months ago (2016-03-07 05:38:25 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-07 06:47:29 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 06:48:54 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0fb38d20480525c24720b73aaca3845dba98082c
Cr-Commit-Position: refs/heads/master@{#379519}

Powered by Google App Engine
This is Rietveld 408576698