Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1760133002: Reland of WTF::bind: Handle movable objects in unbound arguments. (Closed)

Created:
4 years, 9 months ago by Finnur
Modified:
4 years, 9 months ago
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of WTF::bind: Handle movable objects in unbound arguments. (patchset #1 id:1 of https://codereview.chromium.org/1757873002/ ) Reason for revert: Re-landing CL since it didn't fix the leaks. Original issue's description: > Revert of WTF::bind: Handle movable objects in unbound arguments. (patchset #1 id:1 of https://codereview.chromium.org/1744143002/ ) > > Reason for revert: > Speculative revert to see if it fixes leaks in WebKit tests on Linux that started when this CL was checked in: > > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/17815 > > Only two other changes (besides this CL) went into that build (one being Mac only) and this CL happens to be the only checkin to WebKit directly. Will reland if not the culprit. > > Original issue's description: > > WTF::bind: Handle movable objects in unbound arguments. > > > > This patch is the complement to an earlier patch > > (https://codereview.chromium.org/1708183002/), which did the same thing > > for bound arguments. > > > > Fix for unbound arguments is simpler than that for bound arguments. We > > just need to make sure the arguments are passed correctly throughout the > > process. > > > > Due to the current implementation where we use a virtual function to > > implement PartBoundFunctionImpl::operator() we need to copy- or > > move-construct a value there, if the argument's type is not a > > reference. This is extra cost, but it's probably not feasible to get rid > > of this overhead with the current design. > > > > More comments and tests are added accordingly. > > > > BUG=565765 > > R=haraken@chromium.org, hiroshige@chromium.org, tzik@chromium.org > > > > Committed: https://crrev.com/cbf29aa70a0a46e631f77e6b6256a3771a09b994 > > Cr-Commit-Position: refs/heads/master@{#378372} > > TBR=haraken@chromium.org,hiroshige@chromium.org,tzik@chromium.org,mikhail.pozdnyakov@intel.com,yutak@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=565765 > > Committed: https://crrev.com/a55ac737b7029b9057bc021dce6c1ef3788b212e > Cr-Commit-Position: refs/heads/master@{#378746} TBR=haraken@chromium.org,hiroshige@chromium.org,tzik@chromium.org,mikhail.pozdnyakov@intel.com,yutak@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=565765 Committed: https://crrev.com/54fbc836be8606f1a4f65e5b32411f5ffc68750c Cr-Commit-Position: refs/heads/master@{#378995}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -12 lines) Patch
M third_party/WebKit/Source/wtf/Functional.h View 2 chunks +23 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/wtf/FunctionalTest.cpp View 4 chunks +59 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Finnur
Created Reland of WTF::bind: Handle movable objects in unbound arguments.
4 years, 9 months ago (2016-03-03 10:40:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760133002/1
4 years, 9 months ago (2016-03-03 10:40:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 10:41:18 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/54fbc836be8606f1a4f65e5b32411f5ffc68750c Cr-Commit-Position: refs/heads/master@{#378995}
4 years, 9 months ago (2016-03-03 10:42:40 UTC) #5
haraken
4 years, 9 months ago (2016-03-03 11:52:38 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698