Chromium Code Reviews
DescriptionReland of WTF::bind: Handle movable objects in unbound arguments. (patchset #1 id:1 of https://codereview.chromium.org/1757873002/ )
Reason for revert:
Re-landing CL since it didn't fix the leaks.
Original issue's description:
> Revert of WTF::bind: Handle movable objects in unbound arguments. (patchset #1 id:1 of https://codereview.chromium.org/1744143002/ )
>
> Reason for revert:
> Speculative revert to see if it fixes leaks in WebKit tests on Linux that started when this CL was checked in:
>
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/17815
>
> Only two other changes (besides this CL) went into that build (one being Mac only) and this CL happens to be the only checkin to WebKit directly. Will reland if not the culprit.
>
> Original issue's description:
> > WTF::bind: Handle movable objects in unbound arguments.
> >
> > This patch is the complement to an earlier patch
> > (https://codereview.chromium.org/1708183002/), which did the same thing
> > for bound arguments.
> >
> > Fix for unbound arguments is simpler than that for bound arguments. We
> > just need to make sure the arguments are passed correctly throughout the
> > process.
> >
> > Due to the current implementation where we use a virtual function to
> > implement PartBoundFunctionImpl::operator() we need to copy- or
> > move-construct a value there, if the argument's type is not a
> > reference. This is extra cost, but it's probably not feasible to get rid
> > of this overhead with the current design.
> >
> > More comments and tests are added accordingly.
> >
> > BUG=565765
> > R=haraken@chromium.org, hiroshige@chromium.org, tzik@chromium.org
> >
> > Committed: https://crrev.com/cbf29aa70a0a46e631f77e6b6256a3771a09b994
> > Cr-Commit-Position: refs/heads/master@{#378372}
>
> TBR=haraken@chromium.org,hiroshige@chromium.org,tzik@chromium.org,mikhail.pozdnyakov@intel.com,yutak@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=565765
>
> Committed: https://crrev.com/a55ac737b7029b9057bc021dce6c1ef3788b212e
> Cr-Commit-Position: refs/heads/master@{#378746}
TBR=haraken@chromium.org,hiroshige@chromium.org,tzik@chromium.org,mikhail.pozdnyakov@intel.com,yutak@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=565765
Committed: https://crrev.com/54fbc836be8606f1a4f65e5b32411f5ffc68750c
Cr-Commit-Position: refs/heads/master@{#378995}
Patch Set 1 #
Messages
Total messages: 6 (1 generated)
|
||||||||||||||||||||||||||||