LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html - Issue 17601010: [CSS Grid Layout] Rename grid placement properties

Unified Diff: LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html

Issue 17601010: [CSS Grid Layout] Rename grid placement properties (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/grid-item-area-get-set-expected.txt ('k') | LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set-expected.txt » ('j') | LayoutTests/fast/css-grid-layout/resources/grid-item-column-row-parsing-utils.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html

diff --git a/LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html b/LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html

index 290cbf8a9feebde56f32afe8c17054fd3264e2ef..0c89db4e79a04dcc4b144ec66b1a417dcd47e1b7 100755

--- a/LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html

+++ b/LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html

@@ -43,8 +43,8 @@ if (window.testRunner)

grid-row: auto / auto;

}

.gridItemWithBothLongHand {

- grid-end: 11;

- grid-before: 4;

+ grid-column-end: 11;

+ grid-row-start: 4;

}

.gridItemWithNoSpace {

grid-column: auto/1;

@@ -107,11 +107,11 @@ if (window.testRunner)

var element = document.createElement("div");

document.body.appendChild(element);

shouldBe("getComputedStyle(element, '').getPropertyValue('grid-column')", "'auto / auto'");

- shouldBe("getComputedStyle(element, '').getPropertyValue('grid-start')", "'auto'");

- shouldBe("getComputedStyle(element, '').getPropertyValue('grid-end')", "'auto'");

+ shouldBe("getComputedStyle(element, '').getPropertyValue('grid-column-start')", "'auto'");

+ shouldBe("getComputedStyle(element, '').getPropertyValue('grid-column-end')", "'auto'");

shouldBe("getComputedStyle(element, '').getPropertyValue('grid-row')", "'auto / auto'");

- shouldBe("getComputedStyle(element, '').getPropertyValue('grid-before')", "'auto'");

- shouldBe("getComputedStyle(element, '').getPropertyValue('grid-after')", "'auto'");

+ shouldBe("getComputedStyle(element, '').getPropertyValue('grid-row-start')", "'auto'");

+ shouldBe("getComputedStyle(element, '').getPropertyValue('grid-row-end')", "'auto'");

debug("");

debug("Test getting and setting grid-column and grid-row through JS");

@@ -134,20 +134,20 @@ if (window.testRunner)

element.style.gridColumn = "18 / 19";

element.style.gridRow = "66 / 68";

shouldBe("getComputedStyle(element, '').getPropertyValue('grid-column')", "'18 / 19'");

- shouldBe("getComputedStyle(element, '').getPropertyValue('grid-start')", "'18'");

- shouldBe("getComputedStyle(element, '').getPropertyValue('grid-end')", "'19'");

+ shouldBe("getComputedStyle(element, '').getPropertyValue('grid-column-start')", "'18'");

+ shouldBe("getComputedStyle(element, '').getPropertyValue('grid-column-end')", "'19'");

shouldBe("getComputedStyle(element, '').getPropertyValue('grid-row')", "'66 / 68'");

- shouldBe("getComputedStyle(element, '').getPropertyValue('grid-before')", "'66'");

- shouldBe("getComputedStyle(element, '').getPropertyValue('grid-after')", "'68'");

+ shouldBe("getComputedStyle(element, '').getPropertyValue('grid-row-start')", "'66'");

+ shouldBe("getComputedStyle(element, '').getPropertyValue('grid-row-end')", "'68'");

element.style.gridColumn = "auto";

element.style.gridRow = "auto";