Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 176004: Move observers out of automation_provider.cc to declutter the file. (Closed)

Created:
11 years, 3 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
Reviewers:
huanr
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Move observers out of automation_provider.cc to declutter the file. Also make sure they all use DISALLOW_COPY_AND_ASSIGN. TEST=none http://crbug.com/19874 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24702

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+978 lines, -746 lines) Patch
M chrome/browser/automation/automation_provider.cc View 2 chunks +1 line, -746 lines 0 comments Download
A chrome/browser/automation/automation_provider_observers.h View 1 chunk +341 lines, -0 lines 0 comments Download
A chrome/browser/automation/automation_provider_observers.cc View 1 chunk +630 lines, -0 lines 0 comments Download
M chrome/browser/views/find_bar_win_browsertest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paweł Hajdan Jr.
11 years, 3 months ago (2009-08-27 20:30:11 UTC) #1
huanr
11 years, 3 months ago (2009-08-27 23:48:23 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698