src/objects-inl.h - Issue 17600006: CPUProfiler: It is not clear why we are using Handle<Object> for scriptId. Lets flip it into Smi/in…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 17600006: CPUProfiler: It is not clear why we are using Handle<Object> for scriptId. Lets flip it into Smi/in… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: comments addressed Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index 27a626779cfdd24cb22744967cde1076de9e91a7..f3d2a661ae171b64fd658ad2fc35205a6bba37c6 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -4451,7 +4451,7 @@ ACCESSORS(AllocationSiteInfo, payload, Object, kPayloadOffset)

ACCESSORS(Script, source, Object, kSourceOffset)

ACCESSORS(Script, name, Object, kNameOffset)

-ACCESSORS(Script, id, Object, kIdOffset)

+ACCESSORS(Script, id, Smi, kIdOffset)

ACCESSORS_TO_SMI(Script, line_offset, kLineOffsetOffset)

ACCESSORS_TO_SMI(Script, column_offset, kColumnOffsetOffset)

ACCESSORS(Script, data, Object, kDataOffset)

« no previous file with comments | « src/objects.h ('k') | no next file » | no next file with comments »