CPUProfiler: It is not clear why we are using Handle<Object> for scriptId. Lets flip it into Smi/in…

include/v8.h

Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 7074cc0464c0ddbf61c0ccec301815596ff4d7e5..bcb6737f59ab9c5dab978ace85421042d1fcc50e 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -1043,10 +1043,16 @@ class V8EXPORT Script {
 
   /**
    * Returns the script id value.
+   * DEPRECATED: Please use GetId().
    */
   Local<Value> Id();
 
   /**
+   * Returns the script id.
+   */
+  int GetId();
+
+  /**
    * Associate an additional data object with the script. This is mainly used
    * with the debugger as this data object is only available through the
    * debugger API.
@@ -1063,6 +1069,8 @@ class V8EXPORT Script {
    * -1 will be returned if no information available.
    */
   int GetLineNumber(int code_pos);
+
+  static const int kNoScriptId = 0;
 };
 
 
@@ -2347,7 +2355,18 @@ class V8EXPORT Function : public Object {
    * kLineOffsetNotFound if no information available.
    */
   int GetScriptColumnNumber() const;
-  Handle<Value> GetScriptId() const;
+
+  /**
+   * Returns scriptId object.
+   * DEPRECATED: use ScriptId() instead.
+   */
+  V8_DEPRECATED(Handle<Value> GetScriptId() const);

[Jakob Kummerow, 2013/06/25 14:32:13]

I guess you meant to remove the V8_DEPRECATED annotation from the function
declaration.

+
+  /**
+   * Returns scriptId.
+   */
+  int ScriptId() const;
+
   ScriptOrigin GetScriptOrigin() const;
   V8_INLINE(static Function* Cast(Value* obj));
   static const int kLineOffsetNotFound;