Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Side by Side Diff: src/objects.h

Issue 17600006: CPUProfiler: It is not clear why we are using Handle<Object> for scriptId. Lets flip it into Smi/in… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: comments addressed Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/heap-inl.h ('k') | src/objects-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5734 matching lines...) Expand 10 before | Expand all | Expand 10 after
5745 COMPILATION_STATE_COMPILED = 1 5745 COMPILATION_STATE_COMPILED = 1
5746 }; 5746 };
5747 5747
5748 // [source]: the script source. 5748 // [source]: the script source.
5749 DECL_ACCESSORS(source, Object) 5749 DECL_ACCESSORS(source, Object)
5750 5750
5751 // [name]: the script name. 5751 // [name]: the script name.
5752 DECL_ACCESSORS(name, Object) 5752 DECL_ACCESSORS(name, Object)
5753 5753
5754 // [id]: the script id. 5754 // [id]: the script id.
5755 DECL_ACCESSORS(id, Object) 5755 DECL_ACCESSORS(id, Smi)
5756 5756
5757 // [line_offset]: script line offset in resource from where it was extracted. 5757 // [line_offset]: script line offset in resource from where it was extracted.
5758 DECL_ACCESSORS(line_offset, Smi) 5758 DECL_ACCESSORS(line_offset, Smi)
5759 5759
5760 // [column_offset]: script column offset in resource from where it was 5760 // [column_offset]: script column offset in resource from where it was
5761 // extracted. 5761 // extracted.
5762 DECL_ACCESSORS(column_offset, Smi) 5762 DECL_ACCESSORS(column_offset, Smi)
5763 5763
5764 // [data]: additional data associated with this script. 5764 // [data]: additional data associated with this script.
5765 DECL_ACCESSORS(data, Object) 5765 DECL_ACCESSORS(data, Object)
(...skipping 3959 matching lines...) Expand 10 before | Expand all | Expand 10 after
9725 } else { 9725 } else {
9726 value &= ~(1 << bit_position); 9726 value &= ~(1 << bit_position);
9727 } 9727 }
9728 return value; 9728 return value;
9729 } 9729 }
9730 }; 9730 };
9731 9731
9732 } } // namespace v8::internal 9732 } } // namespace v8::internal
9733 9733
9734 #endif // V8_OBJECTS_H_ 9734 #endif // V8_OBJECTS_H_
OLDNEW
« no previous file with comments | « src/heap-inl.h ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698