Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: include/v8.h

Issue 17600006: CPUProfiler: It is not clear why we are using Handle<Object> for scriptId. Lets flip it into Smi/in… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: comments addressed Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1025 matching lines...) Expand 10 before | Expand all | Expand 10 after
1036 * Runs the script returning the resulting value. If the script is 1036 * Runs the script returning the resulting value. If the script is
1037 * context independent (created using ::New) it will be run in the 1037 * context independent (created using ::New) it will be run in the
1038 * currently entered context. If it is context specific (created 1038 * currently entered context. If it is context specific (created
1039 * using ::Compile) it will be run in the context in which it was 1039 * using ::Compile) it will be run in the context in which it was
1040 * compiled. 1040 * compiled.
1041 */ 1041 */
1042 Local<Value> Run(); 1042 Local<Value> Run();
1043 1043
1044 /** 1044 /**
1045 * Returns the script id value. 1045 * Returns the script id value.
1046 * DEPRECATED: Please use GetId().
1046 */ 1047 */
1047 Local<Value> Id(); 1048 Local<Value> Id();
1048 1049
1049 /** 1050 /**
1051 * Returns the script id.
1052 */
1053 int GetId();
1054
1055 /**
1050 * Associate an additional data object with the script. This is mainly used 1056 * Associate an additional data object with the script. This is mainly used
1051 * with the debugger as this data object is only available through the 1057 * with the debugger as this data object is only available through the
1052 * debugger API. 1058 * debugger API.
1053 */ 1059 */
1054 void SetData(Handle<String> data); 1060 void SetData(Handle<String> data);
1055 1061
1056 /** 1062 /**
1057 * Returns the name value of one Script. 1063 * Returns the name value of one Script.
1058 */ 1064 */
1059 Handle<Value> GetScriptName(); 1065 Handle<Value> GetScriptName();
1060 1066
1061 /** 1067 /**
1062 * Returns zero based line number of the code_pos location in the script. 1068 * Returns zero based line number of the code_pos location in the script.
1063 * -1 will be returned if no information available. 1069 * -1 will be returned if no information available.
1064 */ 1070 */
1065 int GetLineNumber(int code_pos); 1071 int GetLineNumber(int code_pos);
1072
1073 static const int kNoScriptId = 0;
1066 }; 1074 };
1067 1075
1068 1076
1069 /** 1077 /**
1070 * An error message. 1078 * An error message.
1071 */ 1079 */
1072 class V8EXPORT Message { 1080 class V8EXPORT Message {
1073 public: 1081 public:
1074 Local<String> Get() const; 1082 Local<String> Get() const;
1075 Local<String> GetSourceLine() const; 1083 Local<String> GetSourceLine() const;
(...skipping 1264 matching lines...) Expand 10 before | Expand all | Expand 10 after
2340 /** 2348 /**
2341 * Returns zero based line number of function body and 2349 * Returns zero based line number of function body and
2342 * kLineOffsetNotFound if no information available. 2350 * kLineOffsetNotFound if no information available.
2343 */ 2351 */
2344 int GetScriptLineNumber() const; 2352 int GetScriptLineNumber() const;
2345 /** 2353 /**
2346 * Returns zero based column number of function body and 2354 * Returns zero based column number of function body and
2347 * kLineOffsetNotFound if no information available. 2355 * kLineOffsetNotFound if no information available.
2348 */ 2356 */
2349 int GetScriptColumnNumber() const; 2357 int GetScriptColumnNumber() const;
2358
2359 /**
2360 * Returns scriptId object.
2361 * DEPRECATED: use ScriptId() instead.
2362 */
2350 Handle<Value> GetScriptId() const; 2363 Handle<Value> GetScriptId() const;
2364
2365 /**
2366 * Returns scriptId.
2367 */
2368 int ScriptId() const;
2369
2351 ScriptOrigin GetScriptOrigin() const; 2370 ScriptOrigin GetScriptOrigin() const;
2352 V8_INLINE(static Function* Cast(Value* obj)); 2371 V8_INLINE(static Function* Cast(Value* obj));
2353 static const int kLineOffsetNotFound; 2372 static const int kLineOffsetNotFound;
2354 2373
2355 private: 2374 private:
2356 Function(); 2375 Function();
2357 static void CheckCast(Value* obj); 2376 static void CheckCast(Value* obj);
2358 }; 2377 };
2359 2378
2360 #ifndef V8_ARRAY_BUFFER_INTERNAL_FIELD_COUNT 2379 #ifndef V8_ARRAY_BUFFER_INTERNAL_FIELD_COUNT
(...skipping 4073 matching lines...) Expand 10 before | Expand all | Expand 10 after
6434 6453
6435 6454
6436 } // namespace v8 6455 } // namespace v8
6437 6456
6438 6457
6439 #undef V8EXPORT 6458 #undef V8EXPORT
6440 #undef TYPE_CHECK 6459 #undef TYPE_CHECK
6441 6460
6442 6461
6443 #endif // V8_H_ 6462 #endif // V8_H_
OLDNEW
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698