Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/objects.h

Issue 17600006: CPUProfiler: It is not clear why we are using Handle<Object> for scriptId. Lets flip it into Smi/in… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5737 matching lines...) Expand 10 before | Expand all | Expand 10 after
5748 COMPILATION_STATE_COMPILED = 1 5748 COMPILATION_STATE_COMPILED = 1
5749 }; 5749 };
5750 5750
5751 // [source]: the script source. 5751 // [source]: the script source.
5752 DECL_ACCESSORS(source, Object) 5752 DECL_ACCESSORS(source, Object)
5753 5753
5754 // [name]: the script name. 5754 // [name]: the script name.
5755 DECL_ACCESSORS(name, Object) 5755 DECL_ACCESSORS(name, Object)
5756 5756
5757 // [id]: the script id. 5757 // [id]: the script id.
5758 DECL_ACCESSORS(id, Object) 5758 DECL_ACCESSORS(id, Smi)
5759 5759
5760 // [line_offset]: script line offset in resource from where it was extracted. 5760 // [line_offset]: script line offset in resource from where it was extracted.
5761 DECL_ACCESSORS(line_offset, Smi) 5761 DECL_ACCESSORS(line_offset, Smi)
5762 5762
5763 // [column_offset]: script column offset in resource from where it was 5763 // [column_offset]: script column offset in resource from where it was
5764 // extracted. 5764 // extracted.
5765 DECL_ACCESSORS(column_offset, Smi) 5765 DECL_ACCESSORS(column_offset, Smi)
5766 5766
5767 // [data]: additional data associated with this script. 5767 // [data]: additional data associated with this script.
5768 DECL_ACCESSORS(data, Object) 5768 DECL_ACCESSORS(data, Object)
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
5813 static const int kTypeOffset = kWrapperOffset + kPointerSize; 5813 static const int kTypeOffset = kWrapperOffset + kPointerSize;
5814 static const int kCompilationTypeOffset = kTypeOffset + kPointerSize; 5814 static const int kCompilationTypeOffset = kTypeOffset + kPointerSize;
5815 static const int kCompilationStateOffset = 5815 static const int kCompilationStateOffset =
5816 kCompilationTypeOffset + kPointerSize; 5816 kCompilationTypeOffset + kPointerSize;
5817 static const int kLineEndsOffset = kCompilationStateOffset + kPointerSize; 5817 static const int kLineEndsOffset = kCompilationStateOffset + kPointerSize;
5818 static const int kIdOffset = kLineEndsOffset + kPointerSize; 5818 static const int kIdOffset = kLineEndsOffset + kPointerSize;
5819 static const int kEvalFromSharedOffset = kIdOffset + kPointerSize; 5819 static const int kEvalFromSharedOffset = kIdOffset + kPointerSize;
5820 static const int kEvalFrominstructionsOffsetOffset = 5820 static const int kEvalFrominstructionsOffsetOffset =
5821 kEvalFromSharedOffset + kPointerSize; 5821 kEvalFromSharedOffset + kPointerSize;
5822 static const int kSize = kEvalFrominstructionsOffsetOffset + kPointerSize; 5822 static const int kSize = kEvalFrominstructionsOffsetOffset + kPointerSize;
5823 static const int kNoScriptId = 0;
Jakob Kummerow 2013/06/25 11:58:39 Please move this somewhere else (e.g. to the begin
loislo 2013/06/25 13:04:53 It was moved to v8::Script.
5823 5824
5824 private: 5825 private:
5825 DISALLOW_IMPLICIT_CONSTRUCTORS(Script); 5826 DISALLOW_IMPLICIT_CONSTRUCTORS(Script);
5826 }; 5827 };
5827 5828
5828 5829
5829 // List of builtin functions we want to identify to improve code 5830 // List of builtin functions we want to identify to improve code
5830 // generation. 5831 // generation.
5831 // 5832 //
5832 // Each entry has a name of a global object property holding an object 5833 // Each entry has a name of a global object property holding an object
(...skipping 3895 matching lines...) Expand 10 before | Expand all | Expand 10 after
9728 } else { 9729 } else {
9729 value &= ~(1 << bit_position); 9730 value &= ~(1 << bit_position);
9730 } 9731 }
9731 return value; 9732 return value;
9732 } 9733 }
9733 }; 9734 };
9734 9735
9735 } } // namespace v8::internal 9736 } } // namespace v8::internal
9736 9737
9737 #endif // V8_OBJECTS_H_ 9738 #endif // V8_OBJECTS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698