Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Issue 1759973002: Add --no-background-compilation to tests that expect to run code in optimized form (Closed)

Created:
4 years, 9 months ago by srdjan
Modified:
4 years, 9 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add --no-background-compilation to tests that expect to run code in optimized form BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/b3405d5ebcc844f3bf7ea76849baef431e294b7d

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : More #

Patch Set 4 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -200 lines) Patch
M runtime/tests/vm/dart/byte_array_optimized_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/tests/vm/dart/byte_array_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/tests/vm/dart/inline_stack_frame_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/big_integer_arith_vm_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/regress_r21715_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/allocation_sinking_inlining_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/arithmetic_canonicalization_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/arithmetic_smi_overflow_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/arithmetic_test.dart View 3 chunks +8 lines, -8 lines 0 comments Download
M tests/language/assert_assignable_type_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/assign_op_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/async_control_structures_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/await_exceptions_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/await_future_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/await_nonfuture_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/await_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/bit_operations_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/bit_shift_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/branch_canonicalization_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/call_closurization_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/call_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/cha_deopt1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/cha_deopt2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/cha_deopt3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/compound_assignment_operator_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/const_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/constant_propagation_phis_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/constant_string_interpolation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/deferred_inlined_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/deferred_load_inval_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/deferred_optimized_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/deopt_inlined_function_lazy_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/deopt_lazy_finalization_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language/deopt_no_feedback_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/deopt_smi_op_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/deoptimized_function_on_stack_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/div_with_power_of_two2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/div_with_power_of_two_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/double_int_addition_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/double_modulo_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/double_nan_comparison_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/equality_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/exception_in_increment_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/fast_method_extraction_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/guess_cid_test.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M tests/language/identical_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/inline_add_constants_to_initial_env_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/inline_closure_with_constant_arguments_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/inline_effect_context_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/inline_getter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/inline_test_context_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/inline_value_context_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/instance_incr_deopt_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/instanceof4_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/instanceof_optimized_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/integer_division_by_zero_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/issue7513_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/issue7525_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/large_implicit_getter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/load_indexed_constant_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/many_generic_instanceof_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/many_overridden_no_such_method_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/mega_load_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/megamorphic_no_such_method_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/mint_arithmetic_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/mint_compares_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/modulo_test.dart View 5 chunks +6 lines, -6 lines 0 comments Download
M tests/language/mul_recipr_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/named_parameters_with_conversions_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/nan_identical_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/no_such_method3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/no_such_method_dispatcher_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/null_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/nullaware_opt_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/number_identity2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/number_identity_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/optimize_redundant_array_load_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/optimized_constant_array_string_access_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/optimized_hoisting_checked_mode_assert_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/optimized_isempty_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/optimized_lists_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/optimized_setter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/optimized_string_charat_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/optimized_string_charcodeat_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/osr_test.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M tests/language/range_analysis_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/regress_11800_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/smi_type_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/strict_equal_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/string_charcode_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/string_intrinsics_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/sync_generator1_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/truncdiv_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language/try_catch2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/try_catch3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/try_catch4_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/try_catch5_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/try_catch_optimized1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/try_catch_optimized2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/try_catch_optimized3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/try_catch_optimized4_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/try_catch_osr_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/try_catch_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language/type_propagation_assert_assignable_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/allocation_sinking_vm_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/canonicalization_preserves_deopt_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/debug_break_enabled_vm_test.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/deopt_hoisted_smi_check_vm_test.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/if_conversion_vm_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/issue11087_vm_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/licm_constant_redefinition_vm_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/load_to_load_forwarding_vm_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/load_to_load_unaligned_forwarding_vm_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/math_vm_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/no_such_method_error_message_vm_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/null_hashcode_optimized_vm_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/optimization_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/optimized_await_regress_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/optimized_check_class_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/optimized_guarded_field_isolates_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/optimized_guarded_field_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/optimized_identical_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language/vm/optimized_polymorphic_list_access_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/optimized_shl_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/optimized_testsmi_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/regress_14903_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/regress_21245_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/regress_22480_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/regress_22541_vm_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/regress_22693_vm_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/regress_23117_vm_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/reusable_boxes_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/store_elimination_vm_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/store_to_load_forwarding_phis_vm_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/string_polymorphic_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/type_propagation_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/vm/typed_data_polymorphic_view_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/uint32_add_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/uint32_right_shift_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/uint32_shift_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/math/double_pow_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/math/min_max_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/float32x4_clamp_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/float32x4_cross_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/float32x4_list_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/float32x4_shuffle_test.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/float32x4_sign_mask_test.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/float32x4_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/float32x4_transpose_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/float32x4_two_arg_shuffle_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/float32x4_unbox_phi_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/float32x4_unbox_regress_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/float64x2_functional_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/float64x2_typed_list_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/int32x4_arithmetic_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/int32x4_bigint_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/int32x4_list_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/int32x4_shuffle_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/int32x4_sign_mask_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/int32x4_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/int64_list_load_store_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/simd_store_to_load_forward_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/simd_type_check_removal.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/typed_data_hierarchy_int64_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/typed_data/typed_data_hierarchy_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/array_bounds_check_generalization_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/double_smi_comparison_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/float_array_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/int_list_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/pair_location_remapping_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/regress_25335_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/slowpath_safepoints_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/typed_data_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/unboxed_int_converter_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
srdjan
4 years, 9 months ago (2016-03-02 22:15:54 UTC) #2
siva
lgtm
4 years, 9 months ago (2016-03-03 00:17:17 UTC) #3
srdjan
4 years, 9 months ago (2016-03-03 00:31:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
b3405d5ebcc844f3bf7ea76849baef431e294b7d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698