MacViews: Handling changing of first responder inside NativeWidgetMac.

ui/views/widget/native_widget_mac_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/views/widget/native_widget_mac.h"
 
 #import <Cocoa/Cocoa.h>
 
 #import "base/mac/foundation_util.h"
 #import "base/mac/scoped_nsobject.h"
@@ skipping 53 matching lines @@
   NSUInteger drawRectCount_;
 
   // The dirtyRect parameter passed to last invocation of drawRect:.
   NSRect lastDirtyRect_;
 }
 
 @property(assign, nonatomic) NSUInteger drawRectCount;
 @property(assign, nonatomic) NSRect lastDirtyRect;
 @end
 
+@interface FocusedNSView : NSView

[tapted, 2016/03/04 00:56:19]

nit: FocusableTestNSView  (name collisions are easy in ObjC, so it's good for
test classes to always have, e.g., "Test" or "Mock" in the name)

[kirr, 2016/03/04 08:31:31]

Done.

+@end
+
 namespace views {
 namespace test {
 
 // BridgedNativeWidget friend to access private members.
 class BridgedNativeWidgetTestApi {
  public:
   explicit BridgedNativeWidgetTestApi(NSWindow* window) {
     bridge_ = NativeWidgetMac::GetBridgeForNativeWindow(window);
   }
 
@@ skipping 1218 matching lines @@
   // These are expected dummy_view bounds in AppKit coordinate system. The y
   // coordinate of rect origin is calculated as:
   // 100(client area height) - 30 (dummy_view's y coordinate) - 15 (dummy view's
   // height).
   gfx::Rect expected_appkit_bounds(25, 55, 10, 15);
   EXPECT_NSEQ(expected_appkit_bounds.ToCGRect(),
               [mock_bridged_view lastDirtyRect]);
   widget->CloseNow();
 }
 
+TEST_F(NativeWidgetMacTest, ChangeFocusOnChangeFirstResponder) {
+  Widget* widget = CreateTopLevelPlatformWidget();
+  widget->GetRootView()->SetFocusable(true);
+  widget->Show();
+
+  base::scoped_nsobject<NSView> child_view(
+      [[FocusedNSView alloc] initWithFrame:[widget->GetNativeView() bounds]]);
+  [widget->GetNativeView() addSubview:child_view];
+  DCHECK_EQ([child_view acceptsFirstResponder], YES);

[tapted, 2016/03/04 00:56:19]

nit: EXPECT_TRUE

[kirr, 2016/03/04 08:31:30]

Done.

+  DCHECK_EQ(widget->GetRootView()->IsFocusable(), YES);

[tapted, 2016/03/04 00:56:19]

EXPECT_TRUE  (somewhat moot here since this won't be compiled on Windows, but I
think MSVC would refuse to compile stuff like this since it's comparing a `char`
with a `bool`)

[kirr, 2016/03/04 08:31:30]

Done.

+
+  FocusManager* manager = widget->GetFocusManager();
+  manager->SetFocusedView(widget->GetRootView());
+  DCHECK_EQ(manager->GetFocusedView(), widget->GetRootView());

[tapted, 2016/03/04 00:56:19]

EXPECT_EQ

[kirr, 2016/03/04 08:31:31]

Done.

+
+  [widget->GetNativeWindow() makeFirstResponder: child_view];

[tapted, 2016/03/04 00:56:19]

nit: no space before `child_view`

[kirr, 2016/03/04 08:31:30]

Done.

+  DCHECK(!manager->GetFocusedView());

[tapted, 2016/03/04 00:56:19]

EXPECT_FALSE

[kirr, 2016/03/04 08:31:31]

Done.

+
+  [widget->GetNativeWindow() makeFirstResponder: widget->GetNativeView()];

[tapted, 2016/03/04 00:56:19]

nit: no space before `widget`.  -- running `git cl format` might actually fix
these up automatically for you

[kirr, 2016/03/04 08:31:30]

Done.
"git cl format" - is super helpful. Thanks a lot.

+  DCHECK_EQ(manager->GetFocusedView(), widget->GetRootView());

[tapted, 2016/03/04 00:56:19]

EXPECT_EQ

[kirr, 2016/03/04 08:31:30]

Done.

+
+  widget->CloseNow();
+}
+
 }  // namespace test
 }  // namespace views
 
 @implementation TestStopAnimationWaiter
 - (void)setWindowStateForEnd {
   views::test::ScopedSwizzleWaiter::GetMethodAndMarkCalled()(self, _cmd);
 }
 @end
 
 @implementation NativeWidgetMacTestWindow
@@ skipping 11 matching lines @@
 
 @synthesize drawRectCount = drawRectCount_;
 @synthesize lastDirtyRect = lastDirtyRect_;
 
 - (void)drawRect:(NSRect)dirtyRect {
   ++drawRectCount_;
   lastDirtyRect_ = dirtyRect;
 }
 
 @end
+
+@implementation FocusedNSView
+- (BOOL)acceptsFirstResponder {
+  return YES;
+}
+@end
+

[tapted, 2016/03/04 00:56:20]

nit: remove trailing blank line

[kirr, 2016/03/04 08:31:30]

Done.