runtime/vm/intrinsifier_arm.cc - Issue 1759913002: Make precompiler work with product mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_arm.cc

Issue 1759913002: Make precompiler work with product mode. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intrinsifier_arm.cc

diff --git a/runtime/vm/intrinsifier_arm.cc b/runtime/vm/intrinsifier_arm.cc

index 0487fead11b3ee87146257051667514513414a3f..086d91d795c34da21f53f396cf22cfa4fa7f45b9 100644

--- a/runtime/vm/intrinsifier_arm.cc

+++ b/runtime/vm/intrinsifier_arm.cc

@@ -2062,7 +2062,7 @@ void Intrinsifier::TwoByteString_equality(Assembler* assembler) {

void Intrinsifier::JSRegExp_ExecuteMatch(Assembler* assembler) {

- if (FLAG_interpret_irregexp) return;

+ if (FLAG_precompiled_mode) return;

rmacnak 2016/03/02 21:12:35 Why not interpret_irregexp? It should work in the

Florian Schneider 2016/03/02 21:48:11 Done.

static const intptr_t kRegExpParamOffset = 2 * kWordSize;

static const intptr_t kStringParamOffset = 1 * kWordSize;