Make precompiler work with product mode.

Make precompiler work with product mode.

For now, change compilation-related flags to be regular
command line options. They won't affect the size of the
precompiled runtime anyway since the compiler is not included
there.

Also introduce a separate switch for precompiled runtime. This can be
 used instead of the macro since it is a compile-time constant in the
 precompiled runtime.

BUG=

Committed: https://github.com/dart-lang/sdk/commit/48b0183926978e909ac0726cffb04c97a3523246

[Florian Schneider, 2016-03-02 20:04:04]

Description was changed from

==========
Make precompiler work with product mode.

For now, change compilation-related flags to be regular
command line options. They won't affect the size of the
precompiled runtime anyway since the compiler is not included
there.

BUG=
==========

to

==========
Make precompiler work with product mode.

For now, change compilation-related flags to be regular
command line options. They won't affect the size of the
precompiled runtime anyway since the compiler is not included
there.

Also introduce a separate switch for precompiled runtime. This can be
 used instead of the macro since it is a compile-time constant in the
 precompiled runtime.

BUG=
==========

[Florian Schneider, 2016-03-02 20:04:13]

fschneider@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2016-03-02 21:12:35]

https://codereview.chromium.org/1759913002/diff/1/runtime/vm/flag_list.h
File runtime/vm/flag_list.h (right):

https://codereview.chromium.org/1759913002/diff/1/runtime/vm/flag_list.h#newc...
runtime/vm/flag_list.h:106: P(reorder_basic_blocks, bool, true,                 
                          \
Probably don't need both this and emit_edge_counters.

https://codereview.chromium.org/1759913002/diff/1/runtime/vm/intrinsifier_arm.cc
File runtime/vm/intrinsifier_arm.cc (right):

https://codereview.chromium.org/1759913002/diff/1/runtime/vm/intrinsifier_arm...
runtime/vm/intrinsifier_arm.cc:2065: if (FLAG_precompiled_mode) return;
Why not interpret_irregexp? It should work in the JIT too.

[Florian Schneider, 2016-03-02 21:48:11]

https://codereview.chromium.org/1759913002/diff/1/runtime/vm/flag_list.h
File runtime/vm/flag_list.h (right):

https://codereview.chromium.org/1759913002/diff/1/runtime/vm/flag_list.h#newc...
runtime/vm/flag_list.h:106: P(reorder_basic_blocks, bool, true,                 
                          \
On 2016/03/02 21:12:35, rmacnak wrote:
> Probably don't need both this and emit_edge_counters.

Done.

https://codereview.chromium.org/1759913002/diff/1/runtime/vm/intrinsifier_arm.cc
File runtime/vm/intrinsifier_arm.cc (right):

https://codereview.chromium.org/1759913002/diff/1/runtime/vm/intrinsifier_arm...
runtime/vm/intrinsifier_arm.cc:2065: if (FLAG_precompiled_mode) return;
On 2016/03/02 21:12:35, rmacnak wrote:
> Why not interpret_irregexp? It should work in the JIT too.

Done.

[Florian Schneider, 2016-03-02 21:59:58]

Description was changed from

==========
Make precompiler work with product mode.

For now, change compilation-related flags to be regular
command line options. They won't affect the size of the
precompiled runtime anyway since the compiler is not included
there.

Also introduce a separate switch for precompiled runtime. This can be
 used instead of the macro since it is a compile-time constant in the
 precompiled runtime.

BUG=
==========

to

==========
Make precompiler work with product mode.

For now, change compilation-related flags to be regular
command line options. They won't affect the size of the
precompiled runtime anyway since the compiler is not included
there.

Also introduce a separate switch for precompiled runtime. This can be
 used instead of the macro since it is a compile-time constant in the
 precompiled runtime.

BUG=

Committed:
https://github.com/dart-lang/sdk/commit/48b0183926978e909ac0726cffb04c97a3523246
==========

[Florian Schneider, 2016-03-02 22:00:00]

Committed patchset #2 (id:20001) manually as
48b0183926978e909ac0726cffb04c97a3523246 (presubmit successful).

[rmacnak, 2016-03-02 22:04:30]

lgtm