Issue 17599008: Stop passing the selector name separately to methods in the enqueuer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17599008: Stop passing the selector name separately to methods in the enqueuer.

Created:
7 years, 6 months ago by kasperl

Modified:
7 years, 6 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Stop passing the selector name separately to methods in the enqueuer. R=ngeoffray@google.com BUG=

Patch Set 1 #

Total comments: 2

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -46 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/enqueue.dart	View	5 chunks	+23 lines, -27 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	5 chunks	+10 lines, -13 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	3 chunks	+5 lines, -5 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! https://codereview.chromium.org/17599008/diff/1/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right): https://codereview.chromium.org/17599008/diff/1/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart#newcode1568 sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:1568: SourceString name = node.selector.name; Remove line above.

7 years, 6 months ago (2013-06-25 12:21:00 UTC) #2

kasperl

Committed patchset #1 manually as r24400 (presubmit successful).

7 years, 6 months ago (2013-06-25 12:28:17 UTC) #3

kasperl

7 years, 6 months ago (2013-06-25 12:28:32 UTC) #4

Thanks for the review.

https://codereview.chromium.org/17599008/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right):

https://codereview.chromium.org/17599008/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:1568: SourceString
name = node.selector.name;
On 2013/06/25 12:21:00, ngeoffray wrote:
> Remove line above.

Done.

Expand Messages | Collapse Messages