Only place primitive objects on the V8 global template.

Only place primitive objects on the V8 global template.
Kill some crummy comments along the way.

BUG=pdfium:419
R=jochen@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/3e44a7bd2b60ace1ee8bc8f48c709056f65c3dc1

[Tom Sepez, 2016-03-02 19:46:24]

Description was changed from

==========
Only place primitive objects on the global template.

BUG=pdfium:419
==========

to

==========
Only place primitive objects on the V8 global template.

BUG=pdfium:419
==========

[Tom Sepez, 2016-03-02 19:46:24]

tsepez@chromium.org changed reviewers:
+ jochen@chromium.org

[Tom Sepez, 2016-03-02 19:46:47]

Jochen, please review.  This implements the approach you outlined in the bug. 
Thanks!

[Tom Sepez, 2016-03-02 19:48:36]

Description was changed from

==========
Only place primitive objects on the V8 global template.

BUG=pdfium:419
==========

to

==========
Only place primitive objects on the V8 global template.
Kill some crummy comments along the way.

BUG=pdfium:419
==========

[Tom Sepez, 2016-03-02 20:02:49]

https://codereview.chromium.org/1759893002/diff/1/fpdfsdk/src/javascript/Cons...
File fpdfsdk/src/javascript/Consts.cpp (right):

https://codereview.chromium.org/1759893002/diff/1/fpdfsdk/src/javascript/Cons...
fpdfsdk/src/javascript/Consts.cpp:103: #define GLOBAL_STRING(rt, name, value)   
                                     \
Note: there are JS tests that these values haven't changed, so you needn't try
to match these up with the old code if you don't want to.

[jochen (gone - plz use gerrit), 2016-03-03 06:50:32]

lgtm

[Charles Lew, 2016-03-03 15:22:09]

I'm curious that after this change, does something like "RE_PHONE_COMMIT ===
RE_PHONE_COMMIT" still evaluates to true?

[Tom Sepez, 2016-03-03 17:54:50]

On 2016/03/03 15:22:09, Charles Lew wrote:
> I'm curious that after this change, does something like "RE_PHONE_COMMIT ===
> RE_PHONE_COMMIT" still evaluates to true?

Excellent question, Charles, let's add a test.

[Tom Sepez, 2016-03-03 18:09:51]

On 2016/03/03 17:54:50, Tom Sepez wrote:
> On 2016/03/03 15:22:09, Charles Lew wrote:
> > I'm curious that after this change, does something like "RE_PHONE_COMMIT ===
> > RE_PHONE_COMMIT" still evaluates to true?
> 
> Excellent question, Charles, let's add a test.

See https://codereview.chromium.org/1761923002/.

[Tom Sepez, 2016-03-03 18:20:39]

On 2016/03/03 18:09:51, Tom Sepez wrote:
> On 2016/03/03 17:54:50, Tom Sepez wrote:
> > On 2016/03/03 15:22:09, Charles Lew wrote:
> > > I'm curious that after this change, does something like "RE_PHONE_COMMIT
===
> > > RE_PHONE_COMMIT" still evaluates to true?
> > 
> > Excellent question, Charles, let's add a test.
> 
> See https://codereview.chromium.org/1761923002/.

The strings remain eq, but the arrays flunks.  

-Alert: Array equality test (==): true
-Alert: Array equality test (===): true
+Alert: Array equality test (==): false
+Alert: Array equality test (===): false

So I have to make but one array for each global context it would seem.

[Tom Sepez, 2016-03-03 19:09:30]

Please review PS#2.

[jochen (gone - plz use gerrit), 2016-03-04 09:45:21]

still lgtm

[Tom Sepez, 2016-03-04 20:25:35]

Description was changed from

==========
Only place primitive objects on the V8 global template.
Kill some crummy comments along the way.

BUG=pdfium:419
==========

to

==========
Only place primitive objects on the V8 global template.
Kill some crummy comments along the way.

BUG=pdfium:419
R=jochen@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/3e44a7bd2b60ace1ee8bc8f48c709056f65c...
==========

[Tom Sepez, 2016-03-04 20:25:37]

Committed patchset #2 (id:20001) manually as
3e44a7bd2b60ace1ee8bc8f48c709056f65c3dc1 (presubmit successful).