Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1759883002: Add template for waterfall state probe/display. (Closed)

Created:
4 years, 9 months ago by dnj
Modified:
4 years, 9 months ago
Reviewers:
estaab, pgervais
CC:
chromium-reviews, infra-reviews+build_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add template for waterfall state probe/display. Enable waterfall status on: - chromiumos BUG=chromium:589145 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299067

Patch Set 1 #

Patch Set 2 : Add chromiumos master. #

Patch Set 3 : Credit Promise implementation. #

Patch Set 4 : Add link, enable for most masters. #

Patch Set 5 : Better comment. #

Patch Set 6 : Add Promise check for safety. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -0 lines) Patch
M masters/master.chromium/templates/layout.html View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A masters/master.chromium/templates/waterfall-state.html View 1 2 3 4 5 1 chunk +97 lines, -0 lines 0 comments Download
A masters/master.tryserver.chromium.linux/templates/layout.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A masters/master.tryserver.chromium.linux/templates/waterfall-state.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
dnj
PTAL
4 years, 9 months ago (2016-03-02 19:38:41 UTC) #3
dnj
(Looks like: https://screenshot.googleplex.com/NbpON5AEJef)
4 years, 9 months ago (2016-03-02 19:39:21 UTC) #4
pgervais
On 2016/03/02 19:39:21, dnj wrote: > (Looks like: https://screenshot.googleplex.com/NbpON5AEJef) lgtm. I think it's worth adding ...
4 years, 9 months ago (2016-03-02 21:43:04 UTC) #5
estaab
Since users won't know what this means can this at least link to a markdown ...
4 years, 9 months ago (2016-03-02 22:09:34 UTC) #7
dnj
On 2016/03/02 22:09:34, estaab wrote: > Since users won't know what this means can this ...
4 years, 9 months ago (2016-03-02 23:44:24 UTC) #8
estaab
lgtm Yay! Drive-by review paid off. :)
4 years, 9 months ago (2016-03-02 23:47:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1759883002/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1759883002/90001
4 years, 9 months ago (2016-03-03 00:29:06 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 00:34:35 UTC) #14
Message was sent while issue was closed.
Committed patchset #6 (id:90001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299067

Powered by Google App Engine
This is Rietveld 408576698