Assembler changes for enabling GrowHeap in Wasm

src/arm/assembler-arm-inl.h

Index: src/arm/assembler-arm-inl.h
diff --git a/src/arm/assembler-arm-inl.h b/src/arm/assembler-arm-inl.h
index 0de96428f33789b66d76d5a1293af8a7276d844d..d5ebae4f849bc2ba4539ddb10cf8f5070ed70bf5 100644
--- a/src/arm/assembler-arm-inl.h
+++ b/src/arm/assembler-arm-inl.h
@@ -67,7 +67,8 @@ void RelocInfo::apply(intptr_t delta) {
 
 
 Address RelocInfo::target_address() {

[titzer, 2016/03/03 18:11:59]

I think we should add new methods to deal specifically with wasm memory
references, as Yang had suggested elsewhere.

[gdeepti1, 2016/03/03 22:59:15]

Done.

-  DCHECK(IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_));
+  DCHECK(IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_) ||
+         IsWasmCodeEntry(rmode_));
   return Assembler::target_address_at(pc_, host_);
 }
 
@@ -103,7 +104,8 @@ int RelocInfo::target_address_size() {
 void RelocInfo::set_target_address(Address target,

[titzer, 2016/03/03 18:11:59]

For the wasm memory reference version of this, I think we should have an
"update" style method, where the caller has to pass the old address and old
size. That's because we'll have memory references into the middle of the wasm
memory (i.e. with some non-zero offset from the start). We don't have to do that
case in this CL, but that will happen in a later one.

[gdeepti1, 2016/03/03 22:59:15]

Added a wasm memory reference version for now. I'll add the changes for updating
references in a follow up CL. 

                                    WriteBarrierMode write_barrier_mode,
                                    ICacheFlushMode icache_flush_mode) {
-  DCHECK(IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_));
+  DCHECK(IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_) ||
+         IsWasmCodeEntry(rmode_));
   Assembler::set_target_address_at(isolate_, pc_, host_, target,
                                    icache_flush_mode);
   if (write_barrier_mode == UPDATE_WRITE_BARRIER &&