third_party/WebKit/LayoutTests/fast/block/float/add-float-back-to-anonymous-block-previous.html - Issue 1759853003: Merge contiguous anonymous blocks after removing a float or out-of-pos-element between them

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/block/float/add-float-back-to-anonymous-block-previous.html

Issue 1759853003: Merge contiguous anonymous blocks after removing a float or out-of-pos-element between them (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@585604-4

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/block/float/add-float-back-to-anonymous-block-previous-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutBlock.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 #div { display:block; float: left; width: 50px; height: 50px; background-color: green; }

	4 #float { width: 50px; height: 50px; background-color: green; float: left; }

	5 </style>

	6 <p>crbug.com/585064: Two contiguous anonymous blocks with inline content should be merged together. There should be a single green rectangle below.</p>

	7 <div style="position: absolute; top: 50px; width: 500px;">
	mstensho (USE GERRIT) 2016/03/04 08:46:24 How about removing the out-of-flow positioning, se How about removing the out-of-flow positioning, setting an id="container" and checkLayout("#container")? I think that would look pretty.
	8 <div style="height: 50px; width: 50px;"></div>

	9 <span>X</span>

	10 <div id="float" data-offset-y=50></div>

	11 <div id="div"></div>

	12 <div id="float" data-offset-y=50></div>
	mstensho (USE GERRIT) 2016/03/04 08:46:24 Duplicate ID #float. Duplicate ID #float.
	13 <span>X</span>

	14 </div>

	15 <script src="../../../resources/check-layout.js"></script>

	16 <script>

	17 document.body.offsetTop;

	18 document.getElementById("div").style.float = 'none';
	mstensho (USE GERRIT) 2016/03/04 08:46:24 Why do you need to unfloat it dynamically first? S Why do you need to unfloat it dynamically first? Seems like an unnecessary step. Couldn't #div just be un-floated initially, then layout, and then set style.float="left" on it?
	19 document.body.offsetTop;

	20 document.getElementById("div").style.float = 'left';

	21 checkLayout("#float");

	22 </script>

OLD	NEW