Scripts to upload and update the mac toolchain.

third_party/mac_sdk/package.py

+#!/usr/bin/env python
+# Copyright (c) 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Compress and upload Xcode sdk files."""
+
+import argparse
+import glob
+import os
+import plistlib
+import re
+import subprocess
+import sys
+import tarfile
+import tempfile
+
+
+SDK_URL = "gs://chrome-mac-sdk"
+
+
+
+EXCLUDE_FOLDERS = [

[erikchen, 2016/03/03 01:45:47]

This will need to be manually updated with each roll? I guess it won't be
necessary if we only need SDKs, right?

How did you decide on these folders? Let's say Xcode8/10.12 SDK comes out. How
am I going to figure out what to add/remove from this list?

[justincohen, 2016/03/03 18:58:33]

Added a comment explaining.  /Platforms!MacOsx gives the most bang for your
buck.  

+'Contents/Applications',
+'Contents/Developer/Documentation',
+'Contents/Developer/Platforms/AppleTVOS.platform',
+'Contents/Developer/Platforms/AppleTVSimulator.platform',
+'Contents/Developer/Platforms/WatchOS.platform',
+'Contents/Developer/Platforms/WatchSimulator.platform',
+'Contents/Developer/Platforms/iPhoneOS.platform',
+'Contents/Developer/Platforms/iPhoneSimulator.platform',
+'Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift-migrator',
+'Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift',
+'Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/usr/share/man',
+'Contents/Developer/Library/Xcode/Templates'
+]
+
+def PrintTarProgress(tarinfo):
+  print 'Adding', tarinfo.name

[erikchen, 2016/03/03 01:45:47]

I'm not a python guru, but I think it's good practice to use the logging module?
Also this is never used. Based on name of function, I wouldn't expect a return
value.

[justincohen, 2016/03/03 18:58:33]

Removed.

+  return tarinfo
+
+
+def main():
+  parser = argparse.ArgumentParser()
+  parser.add_argument('target_dir',
+                      help="Xcode installation contents directory.")
+  parser.add_argument('args', nargs='*', help="run ibtool command")
+  args = parser.parse_args()
+
+  contents_dir = os.path.join(args.target_dir, 'Contents')
+  plist_file = os.path.join(contents_dir, 'version.plist')
+  try:
+    info = plistlib.readPlist(plist_file)
+  except:
+    print "Invalid Xcode contents dir."
+    return 0
+  build_version = info['ProductBuildVersion']
+
+  p = subprocess.Popen(['gsutil.py', '--force-version', '4.15', '--', 'ls',

[erikchen, 2016/03/03 01:45:46]

why --force-version?

[justincohen, 2016/03/03 18:58:33]

Removed.

+                               '%s/sdk-%s-*.tgz' % (SDK_URL, build_version)],
+                               stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+
+  output = p.communicate()[0]
+  next_count = 1
+  if p.returncode == 0:
+    next_count = len(output.split('\n'))
+    sys.stdout.write("%s already exists %s times. "
+                     "Do you want to create another? [y/n] "
+                     % (build_version, next_count - 1))
+
+    if raw_input().lower() not in set(['yes','y', 'ye']):
+      print "Skipping additional upload."
+      return 0
+
+  os.chdir(args.target_dir)
+  sdk_file_name = "sdk-%s-%s" % (build_version, next_count)
+  sdk_name = tempfile.mktemp(suffix='sdk.tgz')

[erikchen, 2016/03/03 01:45:47]

caller is responsible for cleaning up directory afterwards?

[justincohen, 2016/03/03 18:58:33]

Done.

+  print "Creating %s (%s)." % (sdk_file_name, sdk_name)
+  os.environ["COPYFILE_DISABLE"] = "1"
+  args = ['tar', '-cvpzf', sdk_name]

[erikchen, 2016/03/03 01:45:47]

preserve permissions? How does that work when you untar as a different user on a
different machine? Should we just manually fix all permissions on the other end?

[justincohen, 2016/03/03 18:58:33]

Removed 'p'

+  args.extend(map('--exclude={0}'.format, EXCLUDE_FOLDERS))
+  args.extend(['.'])
+  subprocess.check_call(args)
+
+  print "Uploading %s SDK." % sdk_file_name
+  subprocess.check_call(['gsutil.py', '--force-version', '4.15', '--', 'cp',
+                         '-n', '-a', 'public-read', sdk_name,
+                         '%s/%s.tgz' % (SDK_URL, sdk_file_name)])
+  print "Done with %s upload." % sdk_file_name
+  return 0
+
+if __name__ == '__main__':
+  sys.exit(main())