Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 1759673002: [interpreter] Add tests for translating PC from optimized frame. (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 9 months ago
Reviewers:
mythria, rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Add tests for translating PC from optimized frame. R=mythria@chromium.org, rmcilroy@chromium.org BUG=v8:4689 LOG=N Committed: https://crrev.com/db2419c3037d9d3cc75bf262e3c30e3666b8ae97 Cr-Commit-Position: refs/heads/master@{#34434}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : both tests actually fail for ignition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -0 lines) Patch
A test/mjsunit/ignition/optimized-debug-frame.js View 1 chunk +38 lines, -0 lines 0 comments Download
A test/mjsunit/ignition/optimized-stack-trace.js View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Yang
4 years, 9 months ago (2016-03-02 12:47:57 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1759673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1759673002/1
4 years, 9 months ago (2016-03-02 12:53:09 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/3792) v8_win64_rel_ng_triggered on ...
4 years, 9 months ago (2016-03-02 13:14:34 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1759673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1759673002/20001
4 years, 9 months ago (2016-03-02 13:49:20 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/14558)
4 years, 9 months ago (2016-03-02 14:01:17 UTC) #9
Yang
Both tests fail. optimized-stack-trace fails because in FrameSummary, the bytecode offset translated from the PC ...
4 years, 9 months ago (2016-03-02 14:16:38 UTC) #10
mythria
Thanks for the tests and also looking into why they fail. I found a couple ...
4 years, 9 months ago (2016-03-02 14:27:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1759673002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1759673002/40001
4 years, 9 months ago (2016-03-02 14:33:57 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-02 14:53:19 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 14:55:07 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/db2419c3037d9d3cc75bf262e3c30e3666b8ae97
Cr-Commit-Position: refs/heads/master@{#34434}

Powered by Google App Engine
This is Rietveld 408576698