Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1759653005: Revert of respect sRGB when converting from sk to gr configs (Closed)

Created:
4 years, 9 months ago by Brian Osman
Modified:
4 years, 9 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of respect sRGB when converting from sk to gr configs (patchset #1 id:1 of https://codereview.chromium.org/1756913003/ ) Reason for revert: Two major regressions from this change: - Mac images may end up too bright, if they're correctly tagged as sRGB. That's a sub-set of a much larger issue where L32 mode needs to suppress sRGB -> Linear conversion of pretty much everything. - Various low-end GPUs (Mali400 Android, iPad4) don't render in sRGB at all, causing tests to produce no output at all. Original issue's description: > respect sRGB when converting from sk to gr configs > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1756913003 > > Committed: https://skia.googlesource.com/skia/+/c6663dc36b157e40c8225130f5970a346f9ba7c3 TBR=reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/e79586bf82997477b8bc95469147cd25a8e22ff0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/gpu/SkGr.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Osman
Created Revert of respect sRGB when converting from sk to gr configs
4 years, 9 months ago (2016-03-03 20:52:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1759653005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1759653005/1
4 years, 9 months ago (2016-03-03 20:52:48 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 20:52:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e79586bf82997477b8bc95469147cd25a8e22ff0

Powered by Google App Engine
This is Rietveld 408576698