Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: src/interpreter/bytecode-generator.cc

Issue 1759603002: [debugger] Ensure at least one breakable position per function. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | src/interpreter/source-position-table.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/interpreter/bytecode-generator.h" 5 #include "src/interpreter/bytecode-generator.h"
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/compiler.h" 8 #include "src/compiler.h"
9 #include "src/interpreter/bytecode-register-allocator.h" 9 #include "src/interpreter/bytecode-register-allocator.h"
10 #include "src/interpreter/control-flow-builders.h" 10 #include "src/interpreter/control-flow-builders.h"
(...skipping 602 matching lines...) Expand 10 before | Expand all | Expand 10 after
613 // Build assignment to {new.target} variable if it is used. 613 // Build assignment to {new.target} variable if it is used.
614 VisitNewTargetVariable(scope()->new_target_var()); 614 VisitNewTargetVariable(scope()->new_target_var());
615 615
616 // TODO(rmcilroy): Emit tracing call if requested to do so. 616 // TODO(rmcilroy): Emit tracing call if requested to do so.
617 if (FLAG_trace) { 617 if (FLAG_trace) {
618 UNIMPLEMENTED(); 618 UNIMPLEMENTED();
619 } 619 }
620 620
621 // Visit illegal re-declaration and bail out if it exists. 621 // Visit illegal re-declaration and bail out if it exists.
622 if (scope()->HasIllegalRedeclaration()) { 622 if (scope()->HasIllegalRedeclaration()) {
623 VisitForEffect(scope()->GetIllegalRedeclaration()); 623 Expression* illegal = scope()->GetIllegalRedeclaration();
624 builder()->SetExpressionAsStatementPosition(illegal);
625 VisitForEffect(illegal);
624 return; 626 return;
625 } 627 }
626 628
627 // Visit declarations within the function scope. 629 // Visit declarations within the function scope.
628 VisitDeclarations(scope()->declarations()); 630 VisitDeclarations(scope()->declarations());
629 631
630 // Perform a stack-check before the body. 632 // Perform a stack-check before the body.
631 builder()->StackCheck(); 633 builder()->StackCheck();
632 634
633 // Visit statements in the function body. 635 // Visit statements in the function body.
(...skipping 2506 matching lines...) Expand 10 before | Expand all | Expand 10 after
3140 } 3142 }
3141 3143
3142 3144
3143 int BytecodeGenerator::feedback_index(FeedbackVectorSlot slot) const { 3145 int BytecodeGenerator::feedback_index(FeedbackVectorSlot slot) const {
3144 return info()->feedback_vector()->GetIndex(slot); 3146 return info()->feedback_vector()->GetIndex(slot);
3145 } 3147 }
3146 3148
3147 } // namespace interpreter 3149 } // namespace interpreter
3148 } // namespace internal 3150 } // namespace internal
3149 } // namespace v8 3151 } // namespace v8
OLDNEW
« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | src/interpreter/source-position-table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698