Swarming bots: setup for skipping download of build products

Swarming bots: setup for skipping download of build products

Turns out it's pretty easy to pass the compile outputs to the test task by just adding the hash to the "includes" list in the .isolated file.  So the flow is:
1. Isolate skia repo
2. Run compile task, record hash of results
3. Isolate test inputs for DM. This writes a .isolated file
4. Edit the .isolated file from #3 to include the hash from #2
5. Upload the modified .isolated file to the isolate server
6. Trigger the swarming task for DM
7. Wait for DM task to finish, download results from isolate server
8. Upload results to GS as normal

I expect the swarming bots to break when this is committed due to the moved out directory.  The associated recipe change will fix them.

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1759553003

Committed: https://skia.googlesource.com/skia/+/f1215a537f7cb076f0087877899ee2d1a13e5f6c

[borenet, 2016-03-02 21:35:41]

Description was changed from

==========
Swarming bots: setup for skipping download of build products

BUG=skia:4763
==========

to

==========
Swarming bots: setup for skipping download of build products

BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[borenet, 2016-03-02 21:36:07]

Description was changed from

==========
Swarming bots: setup for skipping download of build products

BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Swarming bots: setup for skipping download of build products

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[borenet, 2016-03-02 21:41:50]

Description was changed from

==========
Swarming bots: setup for skipping download of build products

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Swarming bots: setup for skipping download of build products

Turns out it's pretty easy to pass the compile outputs to the test task by just
adding the hash to the "includes" list in the .isolated file.  So the flow is:
1. Isolate skia repo
2. Run compile task, record hash of results
3. Isolate test inputs for DM. This writes a .isolated file
4. Edit the .isolated file from #3 to include the hash from #2
5. Upload the modified .isolated file to the isolate server
6. Trigger the swarming task for DM
7. Wait for DM task to finish, download results from isolate server
8. Upload results to GS as normal

I expect the swarming bots to break when this is committed due to the moved out
directory.  The associated recipe change will fix them.

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[borenet, 2016-03-02 21:42:09]

borenet@google.com changed reviewers:
+ rmistry@google.com

[rmistry, 2016-03-03 16:02:30]

https://codereview.chromium.org/1759553003/diff/1/infra/bots/add_isolated_inp...
File infra/bots/add_isolated_input.py (right):

https://codereview.chromium.org/1759553003/diff/1/infra/bots/add_isolated_inp...
infra/bots/add_isolated_input.py:1: #!/usr/bin/env python
Where is this script used?

[borenet, 2016-03-03 16:18:20]

https://codereview.chromium.org/1759553003/diff/1/infra/bots/add_isolated_inp...
File infra/bots/add_isolated_input.py (right):

https://codereview.chromium.org/1759553003/diff/1/infra/bots/add_isolated_inp...
infra/bots/add_isolated_input.py:1: #!/usr/bin/env python
On 2016/03/03 16:02:30, rmistry wrote:
> Where is this script used?

Nowhere yet.  I was going to call this script from the recipe, but I think I'm
going to use an inline python script which does the same instead.  It's very
useful for local testing though.

[rmistry, 2016-03-03 16:20:07]

Seems a little hacky to modify the .isolated file but if it saves time and there
is no other way currently to do it better lgtm

[borenet, 2016-03-03 16:25:39]

On 2016/03/03 16:20:07, rmistry wrote:
> Seems a little hacky to modify the .isolated file but if it saves time and
there
> is no other way currently to do it better lgtm

Agreed.  This is apparently the best way to go at the moment.

[borenet, 2016-03-04 12:52:52]

The CQ bit was checked by borenet@google.com

[borenet, 2016-03-04 12:52:53]

The patchset sent to the CQ was uploaded after l-g-t-m from rmistry@google.com
Link to the patchset: https://codereview.chromium.org/1759553003/#ps20001
(title: "Fix compile_skia out dir")

[commit-bot: I haz the power, 2016-03-04 12:52:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1759553003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1759553003/20001

[commit-bot: I haz the power, 2016-03-04 12:55:29]

Description was changed from

==========
Swarming bots: setup for skipping download of build products

Turns out it's pretty easy to pass the compile outputs to the test task by just
adding the hash to the "includes" list in the .isolated file.  So the flow is:
1. Isolate skia repo
2. Run compile task, record hash of results
3. Isolate test inputs for DM. This writes a .isolated file
4. Edit the .isolated file from #3 to include the hash from #2
5. Upload the modified .isolated file to the isolate server
6. Trigger the swarming task for DM
7. Wait for DM task to finish, download results from isolate server
8. Upload results to GS as normal

I expect the swarming bots to break when this is committed due to the moved out
directory.  The associated recipe change will fix them.

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Swarming bots: setup for skipping download of build products

Turns out it's pretty easy to pass the compile outputs to the test task by just
adding the hash to the "includes" list in the .isolated file.  So the flow is:
1. Isolate skia repo
2. Run compile task, record hash of results
3. Isolate test inputs for DM. This writes a .isolated file
4. Edit the .isolated file from #3 to include the hash from #2
5. Upload the modified .isolated file to the isolate server
6. Trigger the swarming task for DM
7. Wait for DM task to finish, download results from isolate server
8. Upload results to GS as normal

I expect the swarming bots to break when this is committed due to the moved out
directory.  The associated recipe change will fix them.

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/f1215a537f7cb076f0087877899ee2d1a13e5f6c
==========

[commit-bot: I haz the power, 2016-03-04 12:55:30]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f1215a537f7cb076f0087877899ee2d1a13e5f6c