mus: Server-side implementation of modal windows

components/mus/ws/connection_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/mus/ws/connection_manager.h"
 
 #include "base/logging.h"
 #include "base/stl_util.h"
 #include "components/mus/ws/client_connection.h"
 #include "components/mus/ws/connection_manager_delegate.h"
@@ skipping 657 matching lines @@
        (!window->visible() && window->parent()->IsDrawn()))) {
     SchedulePaint(window->parent(), window->bounds());
   }
 
   for (auto& pair : connection_map_) {
     pair.second->service()->ProcessWillChangeWindowVisibility(
         window, IsOperationSource(pair.first));
   }
 }
 
+void ConnectionManager::OnWindowVisibilityChanged(ServerWindow* window) {

[sky, 2016/03/04 17:00:42]

What if the window is made modal when it's already visible?

Also, you need to potentially prevent capture if a client calls setcapture and
there is a modal window.

[mohsen, 2016/03/05 01:21:53]

Both cases added.

+  if (!window->is_modal() || !window->IsDrawn())
+    return;
+
+  WindowTreeHostImpl* host = GetWindowTreeHostByWindow(window);
+  ServerWindow* capture_window = host->GetCaptureWindow();
+  if (window->transient_parent() &&
+      !window->transient_parent()->Contains(capture_window)) {
+    return;
+  }
+
+  host->SetCapture(nullptr, false);
+}
+
 void ConnectionManager::OnWindowPredefinedCursorChanged(ServerWindow* window,
                                                         int32_t cursor_id) {
   if (in_destructor_)
     return;
 
   ProcessWillChangeWindowPredefinedCursor(window, cursor_id);
 }
 
 void ConnectionManager::OnWindowSharedPropertyChanged(
     ServerWindow* window,
@@ skipping 39 matching lines @@
   if (!got_valid_frame_decorations_) {
     display_manager_observers_.AddInterfacePtr(std::move(observer));
     return;
   }
   CallOnDisplays(observer.get());
   display_manager_observers_.AddInterfacePtr(std::move(observer));
 }
 
 }  // namespace ws
 }  // namespace mus