Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1759483004: pkg/analyzer: import cleanup (Closed)

Created:
4 years, 9 months ago by kevmoo
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/strong_mode.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer/test/reflective_tests.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
kevmoo
4 years, 9 months ago (2016-03-03 00:28:19 UTC) #2
Brian Wilkerson
Other than the one comment, LGTM https://codereview.chromium.org/1759483004/diff/1/pkg/analyzer/lib/src/summary/format.dart File pkg/analyzer/lib/src/summary/format.dart (right): https://codereview.chromium.org/1759483004/diff/1/pkg/analyzer/lib/src/summary/format.dart#newcode5 pkg/analyzer/lib/src/summary/format.dart:5: // This file ...
4 years, 9 months ago (2016-03-03 01:03:42 UTC) #3
kevmoo
https://codereview.chromium.org/1759483004/diff/1/pkg/analyzer/lib/src/summary/format.dart File pkg/analyzer/lib/src/summary/format.dart (right): https://codereview.chromium.org/1759483004/diff/1/pkg/analyzer/lib/src/summary/format.dart#newcode5 pkg/analyzer/lib/src/summary/format.dart:5: // This file has been automatically generated. Please do ...
4 years, 9 months ago (2016-03-03 01:09:39 UTC) #4
kevmoo
4 years, 9 months ago (2016-03-03 01:10:07 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
0ed4df8155d0237ee246706589eb353df187651d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698