Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view.cc

Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix compile errs Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/translate/translate_bubble_view.cc
diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.cc b/chrome/browser/ui/views/translate/translate_bubble_view.cc
index 0b848b8398a06c3fce484818cc528b4d994b6e2b..d18e707ff2ad73f1fbefc159bab93ee3c60e93c5 100644
--- a/chrome/browser/ui/views/translate/translate_bubble_view.cc
+++ b/chrome/browser/ui/views/translate/translate_bubble_view.cc
@@ -120,17 +120,18 @@ views::Widget* TranslateBubbleView::ShowBubble(
new TranslateBubbleModelImpl(step, std::move(ui_delegate)));
TranslateBubbleView* view = new TranslateBubbleView(
anchor_view, std::move(model), error_type, web_contents);
- views::Widget* bubble_widget = views::BubbleDelegateView::CreateBubble(view);
+ views::Widget* bubble_widget =
+ views::BubbleDialogDelegateView::CreateBubble(view);
view->ShowForReason(reason);
return bubble_widget;
}
// static
-void TranslateBubbleView::CloseBubble() {
+void TranslateBubbleView::CloseCurrentBubble() {
if (!translate_bubble_view_)
return;
- translate_bubble_view_->GetWidget()->Close();
+ translate_bubble_view_->CloseBubble();
msw 2016/03/03 23:01:40 optional nit: invert conditional and nest, like ot
Evan Stade 2016/03/07 18:36:38 Done.
}
// static
@@ -213,7 +214,7 @@ bool TranslateBubbleView::AcceleratorPressed(
break;
}
}
- return BubbleDelegateView::AcceleratorPressed(accelerator);
+ return BubbleDialogDelegateView::AcceleratorPressed(accelerator);
}
gfx::Size TranslateBubbleView::GetPreferredSize() const {

Powered by Google App Engine
This is Rietveld 408576698