Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1642)

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix compile errs Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
index 16527db185f9ad395e4122e924b151ff510e00bb..6d8ca5281027f33ed206a92620b193f513aff990 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
@@ -739,7 +739,7 @@ void ManagePasswordsBubbleView::ShowBubble(
manage_passwords_bubble_->set_parent_window(web_contents->GetNativeView());
views::Widget* manage_passwords_bubble_widget =
- views::BubbleDelegateView::CreateBubble(manage_passwords_bubble_);
+ views::BubbleDialogDelegateView::CreateBubble(manage_passwords_bubble_);
if (anchor_view)
manage_passwords_bubble_widget->AddObserver(anchor_view);
@@ -753,9 +753,9 @@ void ManagePasswordsBubbleView::ShowBubble(
}
// static
-void ManagePasswordsBubbleView::CloseBubble() {
+void ManagePasswordsBubbleView::CloseCurrentBubble() {
if (manage_passwords_bubble_)
- manage_passwords_bubble_->Close();
+ manage_passwords_bubble_->CloseBubble();
}
// static
@@ -800,9 +800,9 @@ void ManagePasswordsBubbleView::Init() {
Refresh();
}
-void ManagePasswordsBubbleView::Close() {
+void ManagePasswordsBubbleView::CloseBubble() {
mouse_handler_.reset();
- LocationBarBubbleDelegateView::Close();
+ LocationBarBubbleDelegateView::CloseBubble();
}
base::string16 ManagePasswordsBubbleView::GetWindowTitle() const {

Powered by Google App Engine
This is Rietveld 408576698