chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc - Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix compile errs Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/autofill/save_card_bubble_views.cc ('K') | « chrome/browser/ui/views/location_bar/zoom_bubble_view.cc ('k') | chrome/browser/ui/views/location_bar/zoom_view.h » ('j') | chrome/browser/ui/views/translate/translate_bubble_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

diff --git a/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc b/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

index be76d0fa25c97247deef7056696fc1eab52b2b63..51d6fadfdb2809a010047c1f1ea2a74989a401cd 100644

--- a/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

+++ b/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

@@ -112,7 +112,7 @@ IN_PROC_BROWSER_TEST_F(ZoomBubbleBrowserTest, ImmersiveFullscreen) {

// the zoom bubble was still visible.)

immersive_reveal_lock.reset();

EXPECT_TRUE(immersive_controller->IsRevealed());

- ZoomBubbleView::CloseBubble();

+ ZoomBubbleView::CloseCurrentBubble();

// The zoom bubble is deleted on a task.

content::RunAllPendingInMessageLoop();

EXPECT_FALSE(immersive_controller->IsRevealed());