chrome/browser/ui/views/frame/browser_view.cc - Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix compile errs Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/autofill/save_card_bubble_views.cc ('K') | « chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc ('k') | chrome/browser/ui/views/location_bar/bubble_icon_view.h » ('j') | chrome/browser/ui/views/translate/translate_bubble_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index 303a31b6fddb6d546bfab25efa12940ba5d642c8..76dcd192e5094851aeb7e1513decdbbd3ed79dd8 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -935,8 +935,8 @@ void BrowserView::OnActiveTabChanged(content::WebContents* old_contents,

// Update all the UI bits.

UpdateTitleBar();

- TranslateBubbleView::CloseBubble();

- ZoomBubbleView::CloseBubble();

+ TranslateBubbleView::CloseCurrentBubble();

+ ZoomBubbleView::CloseCurrentBubble();

}

void BrowserView::ZoomChangedForActiveTab(bool can_show_bubble) {