chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc - Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc

Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix ImmersiveFullscreenController Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/wm/immersive_fullscreen_controller.h ('K') | « chrome/browser/ui/views/translate/translate_bubble_view.cc ('k') | chrome/browser/ui/views/translate/translate_icon_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc

diff --git a/chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc b/chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc

index 9a0b9691d40ebe6fedd5ca0406c767ef0187e108..329954e993233b68c4b231a009b1e850491c8751 100644

--- a/chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc

+++ b/chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc

@@ -147,7 +147,7 @@ class TranslateBubbleViewTest : public views::ViewsTestBase {

bubble_ = new TranslateBubbleView(anchor_widget_->GetContentsView(),

std::move(model),

translate::TranslateErrors::NONE, NULL);

- views::BubbleDelegateView::CreateBubble(bubble_)->Show();

+ views::BubbleDialogDelegateView::CreateBubble(bubble_)->Show();

}

void TearDown() override {