chrome/browser/ui/views/passwords/manage_passwords_icon_views.h - Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_icon_views.h

Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix ImmersiveFullscreenController Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/wm/immersive_fullscreen_controller.h ('K') | « chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc ('k') | chrome/browser/ui/views/passwords/manage_passwords_icon_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/passwords/manage_passwords_icon_views.h

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_icon_views.h b/chrome/browser/ui/views/passwords/manage_passwords_icon_views.h

index 23fea160c5a3770eadafa09add8efedb549855b9..a5b8a1023810ba95dede814b5dd893df1d605120 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_icon_views.h

+++ b/chrome/browser/ui/views/passwords/manage_passwords_icon_views.h

@@ -29,7 +29,7 @@ class ManagePasswordsIconViews : public ManagePasswordsIconView,

void OnExecuting(BubbleIconView::ExecuteSource source) override;

bool OnMousePressed(const ui::MouseEvent& event) override;

bool OnKeyPressed(const ui::KeyEvent& event) override;

- views::BubbleDelegateView* GetBubble() const override;

+ views::BubbleDialogDelegateView* GetBubble() const override;

gfx::VectorIconId GetVectorIcon() const override;

// views::View: