chrome/browser/ui/views/location_bar/zoom_view.cc - Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/zoom_view.cc

Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix ImmersiveFullscreenController Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/wm/immersive_fullscreen_controller.h ('K') | « chrome/browser/ui/views/location_bar/zoom_view.h ('k') | chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/zoom_view.cc

diff --git a/chrome/browser/ui/views/location_bar/zoom_view.cc b/chrome/browser/ui/views/location_bar/zoom_view.cc

index fcde26145115736e8e42f15637e5281eec488657..fcd4cd616c24c724fe206130417f59b33cb78d41 100644

--- a/chrome/browser/ui/views/location_bar/zoom_view.cc

+++ b/chrome/browser/ui/views/location_bar/zoom_view.cc

@@ -29,7 +29,7 @@ void ZoomView::Update(ui_zoom::ZoomController* zoom_controller) {

if (!zoom_controller || zoom_controller->IsAtDefaultZoom() ||

location_bar_delegate_->GetToolbarModel()->input_in_progress()) {

SetVisible(false);

- ZoomBubbleView::CloseBubble();

+ ZoomBubbleView::CloseCurrentBubble();

return;

}

@@ -57,7 +57,7 @@ void ZoomView::GetAccessibleState(ui::AXViewState* state) {

state->name = l10n_util::GetStringUTF16(IDS_ACCNAME_ZOOM);

}

-views::BubbleDelegateView* ZoomView::GetBubble() const {

+views::BubbleDialogDelegateView* ZoomView::GetBubble() const {

return ZoomBubbleView::GetZoomBubble();

}