chrome/browser/ui/views/location_bar/location_bar_view.cc - Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.cc

Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix ImmersiveFullscreenController Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/wm/immersive_fullscreen_controller.h ('K') | « chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc ('k') | chrome/browser/ui/views/location_bar/star_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/location_bar_view.cc

diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc

index 46469a67ed8505bce7bc1a15c4f55028a03d7bae..1f24ca97307beb43a0ed70d8bbfa62ac600ca82c 100644

--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc

+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc

@@ -983,7 +983,7 @@ bool LocationBarView::RefreshZoomView() {

const bool was_visible = zoom_view_->visible();

zoom_view_->Update(ui_zoom::ZoomController::FromWebContents(web_contents));

if (!zoom_view_->visible())

- ZoomBubbleView::CloseBubble();

+ ZoomBubbleView::CloseCurrentBubble();

return was_visible != zoom_view_->visible();

}

@@ -1018,7 +1018,7 @@ void LocationBarView::RefreshTranslateIcon() {

command_updater()->UpdateCommandEnabled(IDC_TRANSLATE_PAGE, enabled);

translate_icon_view_->SetVisible(enabled);

if (!enabled)

- TranslateBubbleView::CloseBubble();

+ TranslateBubbleView::CloseCurrentBubble();

}

bool LocationBarView::RefreshManagePasswordsIconView() {