Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Unified Diff: ash/wm/immersive_fullscreen_controller.h

Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix ImmersiveFullscreenController Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/wm/immersive_fullscreen_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/immersive_fullscreen_controller.h
diff --git a/ash/wm/immersive_fullscreen_controller.h b/ash/wm/immersive_fullscreen_controller.h
index 8b3f14135caebc07562aabf7f1715f942e96eff4..a9d761490b2cbbacb1da308e5753c6924dbafca9 100644
--- a/ash/wm/immersive_fullscreen_controller.h
+++ b/ash/wm/immersive_fullscreen_controller.h
@@ -238,9 +238,9 @@ class ASH_EXPORT ImmersiveFullscreenController
// is a bezel sensor above the top container.
bool ShouldHandleGestureEvent(const gfx::Point& location) const;
- // Recreate |bubble_manager_| and start observing any bubbles anchored to a
+ // Recreate |bubble_observer_| and start observing any bubbles anchored to a
// child of |top_container_|.
- void RecreateBubbleManager();
+ void RecreateBubbleObserver();
// Not owned.
Delegate* delegate_;
@@ -288,8 +288,8 @@ class ASH_EXPORT ImmersiveFullscreenController
bool animations_disabled_for_test_;
// Manages bubbles which are anchored to a child of |top_container_|.
- class BubbleManager;
- scoped_ptr<BubbleManager> bubble_manager_;
+ class BubbleObserver;
Evan Stade 2016/03/10 02:17:20 There's already a different class called BubbleMan
+ scoped_ptr<BubbleObserver> bubble_observer_;
base::WeakPtrFactory<ImmersiveFullscreenController> weak_ptr_factory_;
« no previous file with comments | « no previous file | ash/wm/immersive_fullscreen_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698