Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: chrome/browser/ui/views/autofill/save_card_bubble_views.h

Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: unit test Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/autofill/save_card_bubble_views.h
diff --git a/chrome/browser/ui/views/autofill/save_card_bubble_views.h b/chrome/browser/ui/views/autofill/save_card_bubble_views.h
index 34490c4992d23a13aa2a7d72874826b499706690..0a9746f441f8ccffd083701f382fa37d598eeaab 100644
--- a/chrome/browser/ui/views/autofill/save_card_bubble_views.h
+++ b/chrome/browser/ui/views/autofill/save_card_bubble_views.h
@@ -9,7 +9,6 @@
#include "chrome/browser/ui/autofill/save_card_bubble_controller.h"
#include "chrome/browser/ui/autofill/save_card_bubble_view.h"
#include "chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h"
-#include "ui/views/controls/button/button.h"
#include "ui/views/controls/link_listener.h"
#include "ui/views/controls/styled_label_listener.h"
@@ -18,7 +17,6 @@ class WebContents;
}
namespace views {
-class LabelButton;
class Link;
class StyledLabel;
}
@@ -30,7 +28,6 @@ namespace autofill {
// previously saved.
class SaveCardBubbleViews : public SaveCardBubbleView,
public LocationBarBubbleDelegateView,
- public views::ButtonListener,
public views::LinkListener,
public views::StyledLabelListener {
public:
@@ -44,20 +41,22 @@ class SaveCardBubbleViews : public SaveCardBubbleView,
// SaveCardBubbleView
void Hide() override;
- // views::BubbleDelegateView
+ // views::BubbleDialogDelegateView
+ views::View* CreateExtraView() override;
views::View* CreateFootnoteView() override;
+ bool Accept() override;
+ bool Cancel() override;
+ int GetDialogButtons() const override;
+ base::string16 GetDialogButtonLabel(ui::DialogButton button) const override;
+ bool ShouldDefaultButtonBeBlue() const override;
// views::View
gfx::Size GetPreferredSize() const override;
// views::WidgetDelegate
- views::View* GetInitiallyFocusedView() override;
base::string16 GetWindowTitle() const override;
void WindowClosing() override;
- // views::ButtonListener
- void ButtonPressed(views::Button* sender, const ui::Event& event) override;
-
// views::LinkListener
void LinkClicked(views::Link* source, int event_flags) override;
@@ -76,11 +75,6 @@ class SaveCardBubbleViews : public SaveCardBubbleView,
SaveCardBubbleController* controller_; // Weak reference.
- // Button for the user to confirm saving the credit card info.
- views::LabelButton* save_button_;
-
- views::LabelButton* cancel_button_;
-
views::Link* learn_more_link_;
DISALLOW_COPY_AND_ASSIGN(SaveCardBubbleViews);

Powered by Google App Engine
This is Rietveld 408576698