Convert location bar bubble delegates to bubble dialog delegates

ui/views/window/dialog_client_view.cc

Index: ui/views/window/dialog_client_view.cc
diff --git a/ui/views/window/dialog_client_view.cc b/ui/views/window/dialog_client_view.cc
index ea23fed27516f245b46f68958c7d8d556fff1a12..2e47aa6f17f716db002954d1c4d0e2e580a8e72c 100644
--- a/ui/views/window/dialog_client_view.cc
+++ b/ui/views/window/dialog_client_view.cc
@@ -214,6 +214,12 @@ void DialogClientView::Layout() {
 
 bool DialogClientView::AcceleratorPressed(const ui::Accelerator& accelerator) {
   DCHECK_EQ(accelerator.key_code(), ui::VKEY_ESCAPE);
+  // Give the contents view a chance to handle it first.
+  if (contents_view()->HandlesAccelerator(accelerator) &&

[sky, 2016/03/07 21:14:31]

I dislike this because I think it's possible for the view to be called for
AcceleratorPressed twice. I say that because the ordering of targets registered
with the same accelerator depends upon the order the accelerators are added. If
the view is registered first, then it means HandleAccelerator() is called twice
for the view. It won't be detrimental, but it's a bit weird. How about a
delegate method as to whether escape should close?

[Evan Stade, 2016/03/08 01:34:44]

How about this: remove escape handling from DialogClientView and add it to
DialogDelegateView. This way subclass dialogs can override it.

See also patchset 7 for an alternative which I decided was less sensible.

+      contents_view()->AcceleratorPressed(accelerator)) {
+    return true;
+  }
+
   GetWidget()->Close();
   return true;
 }