Convert location bar bubble delegates to bubble dialog delegates

ui/views/window/dialog_client_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/window/dialog_client_view.h"
 
 #include <algorithm>
 
 #include "build/build_config.h"
 #include "ui/events/keycodes/keyboard_codes.h"
@@ skipping 196 matching lines @@
 
   // Layout the contents view to the top and side edges of the contents bounds.
   // NOTE: The local insets do not apply to the contents view sides or top.
   const gfx::Rect contents_bounds = GetContentsBounds();
   contents_view()->SetBounds(contents_bounds.x(), contents_bounds.y(),
       contents_bounds.width(), bounds.bottom() - contents_bounds.y());
 }
 
 bool DialogClientView::AcceleratorPressed(const ui::Accelerator& accelerator) {
   DCHECK_EQ(accelerator.key_code(), ui::VKEY_ESCAPE);
+  // Give the contents view a chance to handle it first.
+  if (contents_view()->HandlesAccelerator(accelerator) &&
+      contents_view()->AcceleratorPressed(accelerator)) {

[msw, 2016/03/03 23:01:40]

Why not just call AcceleratorPressed and avoid the new View api?

[Evan Stade, 2016/03/04 04:12:08]

because many views do something like

AcceleratorPressed(accelerator) {
  DCHECK_EQ(VKEY_RETURN, accelerator);
  // do stuff for return
}

Even if there were no DCHECKs I still think it would be dumb to make all views
write this fn as

if (accelerator == VKEY_RETURN) {
  do something;
}

So, in summary, I don't think AcceleratorPressed should be (and presently isn't)
called for accelerators not registered for.

[msw, 2016/03/04 18:21:08]

Okay, good argument, I suppose I'm in favor of adding HandlesAccelerator.

+    return true;
+  }
+
   GetWidget()->Close();
   return true;
 }
 
 void DialogClientView::ViewHierarchyChanged(
     const ViewHierarchyChangedDetails& details) {
   ClientView::ViewHierarchyChanged(details);
   if (details.is_add && details.child == this) {
     UpdateDialogButtons();
     CreateExtraView();
@@ skipping 133 matching lines @@
       child_views.end());
 
   // Setup focus.
   for (size_t i = 0; i < child_views.size(); i++) {
     child_views[i]->SetNextFocusableView(
         i + 1 != child_views.size() ? child_views[i + 1] : nullptr);
   }
 }
 
 }  // namespace views