Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix ImmersiveFullscreenController Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/location_bar/zoom_bubble_view.h" 5 #include "chrome/browser/ui/views/location_bar/zoom_bubble_view.h"
6 6
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 #include "chrome/browser/ui/browser_commands.h" 8 #include "chrome/browser/ui/browser_commands.h"
9 #include "chrome/browser/ui/exclusive_access/fullscreen_controller.h" 9 #include "chrome/browser/ui/exclusive_access/fullscreen_controller.h"
10 #include "chrome/browser/ui/exclusive_access/fullscreen_controller_test.h" 10 #include "chrome/browser/ui/exclusive_access/fullscreen_controller_test.h"
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 // An immersive reveal should hide the zoom bubble. 96 // An immersive reveal should hide the zoom bubble.
97 scoped_ptr<ImmersiveRevealedLock> immersive_reveal_lock( 97 scoped_ptr<ImmersiveRevealedLock> immersive_reveal_lock(
98 immersive_controller->GetRevealedLock( 98 immersive_controller->GetRevealedLock(
99 ImmersiveModeController::ANIMATE_REVEAL_NO)); 99 ImmersiveModeController::ANIMATE_REVEAL_NO));
100 ASSERT_TRUE(immersive_controller->IsRevealed()); 100 ASSERT_TRUE(immersive_controller->IsRevealed());
101 EXPECT_EQ(NULL, ZoomBubbleView::zoom_bubble_); 101 EXPECT_EQ(NULL, ZoomBubbleView::zoom_bubble_);
102 102
103 // The zoom bubble should be anchored when it is shown in immersive fullscreen 103 // The zoom bubble should be anchored when it is shown in immersive fullscreen
104 // and the top-of-window views are revealed. 104 // and the top-of-window views are revealed.
105 ZoomBubbleView::ShowBubble(web_contents, ZoomBubbleView::AUTOMATIC); 105 ZoomBubbleView::ShowBubble(web_contents, ZoomBubbleView::AUTOMATIC);
106 ASSERT_TRUE(ZoomBubbleView::GetZoomBubble());
107 zoom_bubble = ZoomBubbleView::GetZoomBubble(); 106 zoom_bubble = ZoomBubbleView::GetZoomBubble();
107 ASSERT_TRUE(zoom_bubble);
108 EXPECT_TRUE(zoom_bubble->GetAnchorView()); 108 EXPECT_TRUE(zoom_bubble->GetAnchorView());
109 109
110 // The top-of-window views should not hide till the zoom bubble hides. (It 110 // The top-of-window views should not hide till the zoom bubble hides. (It
111 // would be weird if the view to which the zoom bubble is anchored hid while 111 // would be weird if the view to which the zoom bubble is anchored hid while
112 // the zoom bubble was still visible.) 112 // the zoom bubble was still visible.)
113 immersive_reveal_lock.reset(); 113 immersive_reveal_lock.reset();
114 EXPECT_TRUE(immersive_controller->IsRevealed()); 114 EXPECT_TRUE(immersive_controller->IsRevealed());
115 ZoomBubbleView::CloseBubble(); 115 ZoomBubbleView::CloseCurrentBubble();
116 // The zoom bubble is deleted on a task. 116 // The zoom bubble is deleted on a task.
117 content::RunAllPendingInMessageLoop(); 117 content::RunAllPendingInMessageLoop();
118 EXPECT_FALSE(immersive_controller->IsRevealed()); 118 EXPECT_FALSE(immersive_controller->IsRevealed());
119 119
120 // Exit fullscreen before ending the test for the sake of sanity. 120 // Exit fullscreen before ending the test for the sake of sanity.
121 { 121 {
122 scoped_ptr<FullscreenNotificationObserver> waiter( 122 scoped_ptr<FullscreenNotificationObserver> waiter(
123 new FullscreenNotificationObserver()); 123 new FullscreenNotificationObserver());
124 chrome::ToggleFullscreenMode(browser()); 124 chrome::ToggleFullscreenMode(browser());
125 waiter->Wait(); 125 waiter->Wait();
126 } 126 }
127 } 127 }
128 #endif // OS_CHROMEOS 128 #endif // OS_CHROMEOS
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698