Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Side by Side Diff: ash/wm/immersive_fullscreen_controller.h

Issue 1759453002: Convert location bar bubble delegates to bubble dialog delegates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix ImmersiveFullscreenController Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ash/wm/immersive_fullscreen_controller.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_WM_IMMERSIVE_FULLSCREEN_CONTROLLER_H_ 5 #ifndef ASH_WM_IMMERSIVE_FULLSCREEN_CONTROLLER_H_
6 #define ASH_WM_IMMERSIVE_FULLSCREEN_CONTROLLER_H_ 6 #define ASH_WM_IMMERSIVE_FULLSCREEN_CONTROLLER_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "ash/ash_export.h" 10 #include "ash/ash_export.h"
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 const gfx::Point& location_in_screen) const; 231 const gfx::Point& location_in_screen) const;
232 232
233 // True when |location| is "near" to the top container. When the top container 233 // True when |location| is "near" to the top container. When the top container
234 // is not closed "near" means within the displayed bounds or above it. When 234 // is not closed "near" means within the displayed bounds or above it. When
235 // the top container is closed "near" means either within the displayed 235 // the top container is closed "near" means either within the displayed
236 // bounds, above it, or within a few pixels below it. This allow the container 236 // bounds, above it, or within a few pixels below it. This allow the container
237 // to steal enough pixels to detect a swipe in and handles the case that there 237 // to steal enough pixels to detect a swipe in and handles the case that there
238 // is a bezel sensor above the top container. 238 // is a bezel sensor above the top container.
239 bool ShouldHandleGestureEvent(const gfx::Point& location) const; 239 bool ShouldHandleGestureEvent(const gfx::Point& location) const;
240 240
241 // Recreate |bubble_manager_| and start observing any bubbles anchored to a 241 // Recreate |bubble_observer_| and start observing any bubbles anchored to a
242 // child of |top_container_|. 242 // child of |top_container_|.
243 void RecreateBubbleManager(); 243 void RecreateBubbleObserver();
244 244
245 // Not owned. 245 // Not owned.
246 Delegate* delegate_; 246 Delegate* delegate_;
247 views::View* top_container_; 247 views::View* top_container_;
248 views::Widget* widget_; 248 views::Widget* widget_;
249 aura::Window* native_window_; 249 aura::Window* native_window_;
250 250
251 // True if the observers have been enabled. 251 // True if the observers have been enabled.
252 bool observers_enabled_; 252 bool observers_enabled_;
253 253
(...skipping 27 matching lines...) Expand all
281 // a view is not focusable till a reveal has made it visible. 281 // a view is not focusable till a reveal has made it visible.
282 scoped_ptr<ImmersiveRevealedLock> focus_revealed_lock_; 282 scoped_ptr<ImmersiveRevealedLock> focus_revealed_lock_;
283 283
284 // The animation which controls sliding the top-of-window views in and out. 284 // The animation which controls sliding the top-of-window views in and out.
285 scoped_ptr<gfx::SlideAnimation> animation_; 285 scoped_ptr<gfx::SlideAnimation> animation_;
286 286
287 // Whether the animations are disabled for testing. 287 // Whether the animations are disabled for testing.
288 bool animations_disabled_for_test_; 288 bool animations_disabled_for_test_;
289 289
290 // Manages bubbles which are anchored to a child of |top_container_|. 290 // Manages bubbles which are anchored to a child of |top_container_|.
291 class BubbleManager; 291 class BubbleObserver;
Evan Stade 2016/03/10 02:17:20 There's already a different class called BubbleMan
292 scoped_ptr<BubbleManager> bubble_manager_; 292 scoped_ptr<BubbleObserver> bubble_observer_;
293 293
294 base::WeakPtrFactory<ImmersiveFullscreenController> weak_ptr_factory_; 294 base::WeakPtrFactory<ImmersiveFullscreenController> weak_ptr_factory_;
295 295
296 DISALLOW_COPY_AND_ASSIGN(ImmersiveFullscreenController); 296 DISALLOW_COPY_AND_ASSIGN(ImmersiveFullscreenController);
297 }; 297 };
298 298
299 } // namespace ash 299 } // namespace ash
300 300
301 #endif // ASH_WM_IMMERSIVE_FULLSCREEN_CONTROLLER_H_ 301 #endif // ASH_WM_IMMERSIVE_FULLSCREEN_CONTROLLER_H_
OLDNEW
« no previous file with comments | « no previous file | ash/wm/immersive_fullscreen_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698