gpu/command_buffer/service/feature_info.cc - Issue 1759433002: Update GL_IMPLEMENTATION_COLOR_READ_FORMAT for BGRA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/feature_info.cc

Issue 1759433002: Update GL_IMPLEMENTATION_COLOR_READ_FORMAT for BGRA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: feedback Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/feature_info.h ('k') | gpu/command_buffer/service/feature_info_unittest.cc » ('j') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/feature_info.cc

diff --git a/gpu/command_buffer/service/feature_info.cc b/gpu/command_buffer/service/feature_info.cc

index 73fb0eab56f3fa92067fc43f413084c80d019646..a0ebe050a743ddc440dd5054683cbb36a29ec389 100644

--- a/gpu/command_buffer/service/feature_info.cc

+++ b/gpu/command_buffer/service/feature_info.cc

@@ -178,7 +178,8 @@ FeatureInfo::FeatureFlags::FeatureFlags()

emulate_primitive_restart_fixed_index(false),

ext_render_buffer_format_bgra8888(false),

ext_multisample_compatibility(false),

- ext_blend_func_extended(false) {}

+ ext_blend_func_extended(false),

+ ext_read_format_bgra(false) {}

FeatureInfo::Workarounds::Workarounds() :

#define GPU_OP(type, name) name(false),

@@ -647,6 +648,7 @@ void FeatureInfo::InitializeFeatures() {

}

if (enable_read_format_bgra) {

+ feature_flags_.ext_read_format_bgra = true;

AddExtensionString("GL_EXT_read_format_bgra");

validators_.read_pixel_format.AddValue(GL_BGRA_EXT);

}