Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: gpu/command_buffer/service/feature_info_unittest.cc

Issue 1759433002: Update GL_IMPLEMENTATION_COLOR_READ_FORMAT for BGRA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: feedback Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/feature_info.h" 5 #include "gpu/command_buffer/service/feature_info.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 ).use_arb_occlusion_query2_for_occlusion_query_boolean); 194 ).use_arb_occlusion_query2_for_occlusion_query_boolean);
195 EXPECT_FALSE(info_->feature_flags( 195 EXPECT_FALSE(info_->feature_flags(
196 ).use_arb_occlusion_query_for_occlusion_query_boolean); 196 ).use_arb_occlusion_query_for_occlusion_query_boolean);
197 EXPECT_FALSE(info_->feature_flags().native_vertex_array_object); 197 EXPECT_FALSE(info_->feature_flags().native_vertex_array_object);
198 EXPECT_FALSE(info_->feature_flags().map_buffer_range); 198 EXPECT_FALSE(info_->feature_flags().map_buffer_range);
199 EXPECT_FALSE(info_->feature_flags().use_async_readpixels); 199 EXPECT_FALSE(info_->feature_flags().use_async_readpixels);
200 EXPECT_FALSE(info_->feature_flags().ext_draw_buffers); 200 EXPECT_FALSE(info_->feature_flags().ext_draw_buffers);
201 EXPECT_FALSE(info_->feature_flags().nv_draw_buffers); 201 EXPECT_FALSE(info_->feature_flags().nv_draw_buffers);
202 EXPECT_FALSE(info_->feature_flags().ext_discard_framebuffer); 202 EXPECT_FALSE(info_->feature_flags().ext_discard_framebuffer);
203 EXPECT_FALSE(info_->feature_flags().angle_depth_texture); 203 EXPECT_FALSE(info_->feature_flags().angle_depth_texture);
204 EXPECT_FALSE(info_->feature_flags().ext_read_format_bgra);
204 205
205 #define GPU_OP(type, name) EXPECT_FALSE(info_->workarounds().name); 206 #define GPU_OP(type, name) EXPECT_FALSE(info_->workarounds().name);
206 GPU_DRIVER_BUG_WORKAROUNDS(GPU_OP) 207 GPU_DRIVER_BUG_WORKAROUNDS(GPU_OP)
207 #undef GPU_OP 208 #undef GPU_OP
208 EXPECT_EQ(0, info_->workarounds().max_texture_size); 209 EXPECT_EQ(0, info_->workarounds().max_texture_size);
209 EXPECT_EQ(0, info_->workarounds().max_cube_map_texture_size); 210 EXPECT_EQ(0, info_->workarounds().max_cube_map_texture_size);
210 EXPECT_FALSE(info_->workarounds().gl_clear_broken); 211 EXPECT_FALSE(info_->workarounds().gl_clear_broken);
211 } 212 }
212 213
213 TEST_P(FeatureInfoTest, InitializeNoExtensions) { 214 TEST_P(FeatureInfoTest, InitializeNoExtensions) {
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
391 392
392 TEST_P(FeatureInfoTest, InitializeEXT_texture_format_BGRA8888GL) { 393 TEST_P(FeatureInfoTest, InitializeEXT_texture_format_BGRA8888GL) {
393 SetupInitExpectations("GL_EXT_bgra"); 394 SetupInitExpectations("GL_EXT_bgra");
394 EXPECT_THAT(info_->extensions(), 395 EXPECT_THAT(info_->extensions(),
395 HasSubstr("GL_EXT_texture_format_BGRA8888")); 396 HasSubstr("GL_EXT_texture_format_BGRA8888"));
396 EXPECT_THAT(info_->extensions(), 397 EXPECT_THAT(info_->extensions(),
397 HasSubstr("GL_EXT_read_format_bgra")); 398 HasSubstr("GL_EXT_read_format_bgra"));
398 EXPECT_THAT(info_->extensions(), 399 EXPECT_THAT(info_->extensions(),
399 HasSubstr("GL_CHROMIUM_renderbuffer_format_BGRA8888")); 400 HasSubstr("GL_CHROMIUM_renderbuffer_format_BGRA8888"));
400 EXPECT_TRUE(info_->feature_flags().ext_render_buffer_format_bgra8888); 401 EXPECT_TRUE(info_->feature_flags().ext_render_buffer_format_bgra8888);
402 EXPECT_TRUE(info_->feature_flags().ext_read_format_bgra);
401 EXPECT_TRUE(info_->validators()->texture_format.IsValid( 403 EXPECT_TRUE(info_->validators()->texture_format.IsValid(
402 GL_BGRA_EXT)); 404 GL_BGRA_EXT));
403 EXPECT_TRUE(info_->validators()->texture_internal_format.IsValid( 405 EXPECT_TRUE(info_->validators()->texture_internal_format.IsValid(
404 GL_BGRA_EXT)); 406 GL_BGRA_EXT));
405 EXPECT_TRUE(info_->validators()->read_pixel_format.IsValid( 407 EXPECT_TRUE(info_->validators()->read_pixel_format.IsValid(
406 GL_BGRA_EXT)); 408 GL_BGRA_EXT));
407 EXPECT_TRUE(info_->validators()->render_buffer_format.IsValid( 409 EXPECT_TRUE(info_->validators()->render_buffer_format.IsValid(
408 GL_BGRA8_EXT)); 410 GL_BGRA8_EXT));
409 } 411 }
410 412
411 TEST_P(FeatureInfoTest, InitializeEXT_texture_format_BGRA8888Apple) { 413 TEST_P(FeatureInfoTest, InitializeEXT_texture_format_BGRA8888Apple) {
412 SetupInitExpectations("GL_APPLE_texture_format_BGRA8888"); 414 SetupInitExpectations("GL_APPLE_texture_format_BGRA8888");
413 EXPECT_THAT(info_->extensions(), 415 EXPECT_THAT(info_->extensions(),
414 HasSubstr("GL_EXT_texture_format_BGRA8888")); 416 HasSubstr("GL_EXT_texture_format_BGRA8888"));
415 EXPECT_TRUE(info_->validators()->texture_format.IsValid( 417 EXPECT_TRUE(info_->validators()->texture_format.IsValid(
416 GL_BGRA_EXT)); 418 GL_BGRA_EXT));
417 EXPECT_TRUE(info_->validators()->texture_internal_format.IsValid( 419 EXPECT_TRUE(info_->validators()->texture_internal_format.IsValid(
418 GL_BGRA_EXT)); 420 GL_BGRA_EXT));
419 EXPECT_FALSE(info_->validators()->render_buffer_format.IsValid( 421 EXPECT_FALSE(info_->validators()->render_buffer_format.IsValid(
420 GL_BGRA8_EXT)); 422 GL_BGRA8_EXT));
421 EXPECT_FALSE(info_->feature_flags().ext_render_buffer_format_bgra8888); 423 EXPECT_FALSE(info_->feature_flags().ext_render_buffer_format_bgra8888);
422 } 424 }
423 425
424 TEST_P(FeatureInfoTest, InitializeGLES2EXT_read_format_bgra) { 426 TEST_P(FeatureInfoTest, InitializeGLES2EXT_read_format_bgra) {
425 SetupInitExpectationsWithGLVersion( 427 SetupInitExpectationsWithGLVersion(
426 "GL_EXT_read_format_bgra", "", "OpenGL ES 2.0"); 428 "GL_EXT_read_format_bgra", "", "OpenGL ES 2.0");
427 EXPECT_THAT(info_->extensions(), 429 EXPECT_THAT(info_->extensions(),
428 HasSubstr("GL_EXT_read_format_bgra")); 430 HasSubstr("GL_EXT_read_format_bgra"));
431 EXPECT_TRUE(info_->feature_flags().ext_read_format_bgra);
429 EXPECT_FALSE(info_->validators()->texture_format.IsValid( 432 EXPECT_FALSE(info_->validators()->texture_format.IsValid(
430 GL_BGRA_EXT)); 433 GL_BGRA_EXT));
431 EXPECT_FALSE(info_->validators()->texture_internal_format.IsValid( 434 EXPECT_FALSE(info_->validators()->texture_internal_format.IsValid(
432 GL_BGRA_EXT)); 435 GL_BGRA_EXT));
433 EXPECT_TRUE(info_->validators()->read_pixel_format.IsValid( 436 EXPECT_TRUE(info_->validators()->read_pixel_format.IsValid(
434 GL_BGRA_EXT)); 437 GL_BGRA_EXT));
435 EXPECT_FALSE(info_->validators()->render_buffer_format.IsValid( 438 EXPECT_FALSE(info_->validators()->render_buffer_format.IsValid(
436 GL_BGRA8_EXT)); 439 GL_BGRA8_EXT));
437 EXPECT_FALSE(info_->feature_flags().ext_render_buffer_format_bgra8888); 440 EXPECT_FALSE(info_->feature_flags().ext_render_buffer_format_bgra8888);
438 } 441 }
439 442
440 TEST_P(FeatureInfoTest, InitializeEXT_read_format_bgra) { 443 TEST_P(FeatureInfoTest, InitializeEXT_read_format_bgra) {
441 SetupInitExpectations("GL_EXT_read_format_bgra"); 444 SetupInitExpectations("GL_EXT_read_format_bgra");
442 EXPECT_THAT(info_->extensions(), 445 EXPECT_THAT(info_->extensions(),
443 HasSubstr("GL_EXT_read_format_bgra")); 446 HasSubstr("GL_EXT_read_format_bgra"));
447 EXPECT_TRUE(info_->feature_flags().ext_read_format_bgra);
444 EXPECT_TRUE(info_->validators()->texture_format.IsValid( 448 EXPECT_TRUE(info_->validators()->texture_format.IsValid(
445 GL_BGRA_EXT)); 449 GL_BGRA_EXT));
446 EXPECT_TRUE(info_->validators()->texture_internal_format.IsValid( 450 EXPECT_TRUE(info_->validators()->texture_internal_format.IsValid(
447 GL_BGRA_EXT)); 451 GL_BGRA_EXT));
448 EXPECT_TRUE(info_->validators()->read_pixel_format.IsValid( 452 EXPECT_TRUE(info_->validators()->read_pixel_format.IsValid(
449 GL_BGRA_EXT)); 453 GL_BGRA_EXT));
450 EXPECT_FALSE(info_->validators()->render_buffer_format.IsValid( 454 EXPECT_FALSE(info_->validators()->render_buffer_format.IsValid(
451 GL_BGRA8_EXT)); 455 GL_BGRA8_EXT));
452 EXPECT_FALSE(info_->feature_flags().ext_render_buffer_format_bgra8888); 456 EXPECT_FALSE(info_->feature_flags().ext_render_buffer_format_bgra8888);
453 } 457 }
(...skipping 987 matching lines...) Expand 10 before | Expand all | Expand 10 after
1441 base::IntToString(gpu::DISABLE_MSAA_ON_NON_WEBGL_CONTEXTS)); 1445 base::IntToString(gpu::DISABLE_MSAA_ON_NON_WEBGL_CONTEXTS));
1442 SetupInitExpectationsWithGLVersionAndContextTypeAndCommandLine( 1446 SetupInitExpectationsWithGLVersionAndContextTypeAndCommandLine(
1443 "GL_EXT_multisampled_render_to_texture GL_EXT_framebuffer_multisample", 1447 "GL_EXT_multisampled_render_to_texture GL_EXT_framebuffer_multisample",
1444 "", "", CONTEXT_TYPE_WEBGL1, command_line); 1448 "", "", CONTEXT_TYPE_WEBGL1, command_line);
1445 EXPECT_TRUE(info_->feature_flags().multisampled_render_to_texture); 1449 EXPECT_TRUE(info_->feature_flags().multisampled_render_to_texture);
1446 EXPECT_TRUE(info_->feature_flags().chromium_framebuffer_multisample); 1450 EXPECT_TRUE(info_->feature_flags().chromium_framebuffer_multisample);
1447 } 1451 }
1448 1452
1449 } // namespace gles2 1453 } // namespace gles2
1450 } // namespace gpu 1454 } // namespace gpu
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698