Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1250)

Issue 1759413002: FocusController::setInitialFocus should ignore sequential focus navigation starting point. (Closed)

Created:
4 years, 9 months ago by tkent
Modified:
4 years, 9 months ago
Reviewers:
kochi
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

FocusController::setInitialFocus should ignore sequential focus navigation starting point. If an element was focused before calling setInitialFocus(), we unexpectedly started to search for focus candidates at the last focused element. BUG=591612 TEST=automated Committed: https://crrev.com/97e1c9eed32d48ac464dcd5ee482c8123f8b810f Cr-Commit-Position: refs/heads/master@{#379223}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/FocusController.cpp View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/core/page/FocusControllerTest.cpp View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
tkent
kochi@, would you review this please?
4 years, 9 months ago (2016-03-04 01:47:35 UTC) #2
kochi
Wow, thanks for adding the unit test! lgtm
4 years, 9 months ago (2016-03-04 02:45:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1759413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1759413002/1
4 years, 9 months ago (2016-03-04 03:33:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 05:59:31 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 06:00:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97e1c9eed32d48ac464dcd5ee482c8123f8b810f
Cr-Commit-Position: refs/heads/master@{#379223}

Powered by Google App Engine
This is Rietveld 408576698