src/compiler/ia32/instruction-selector-ia32.cc - Issue 1759383003: [compiler] Add relocatable pointer constants for wasm memory references.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ia32/instruction-selector-ia32.cc

Issue 1759383003: [compiler] Add relocatable pointer constants for wasm memory references. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix uninitialized variable causing msan failure Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/ia32/instruction-selector-ia32.cc

diff --git a/src/compiler/ia32/instruction-selector-ia32.cc b/src/compiler/ia32/instruction-selector-ia32.cc

index 5c4acce6735bd339dbb5a8c808c94b685ecbe09e..0d5cf4ed48a4861321b2c4ad62acccc395e822ad 100644

--- a/src/compiler/ia32/instruction-selector-ia32.cc

+++ b/src/compiler/ia32/instruction-selector-ia32.cc

@@ -56,6 +56,8 @@ class IA32OperandGenerator final : public OperandGenerator {

case IrOpcode::kInt32Constant:

case IrOpcode::kNumberConstant:

case IrOpcode::kExternalConstant:

+ case IrOpcode::kRelocatableInt32Constant:

+ case IrOpcode::kRelocatableInt64Constant:

return true;

case IrOpcode::kHeapConstant: {

// Constants in new space cannot be used as immediates in V8 because

« no previous file with comments | « src/compiler/ia32/code-generator-ia32.cc ('k') | src/compiler/instruction.h » ('j') | no next file with comments »