src/compiler/verifier.cc - Issue 1759383003: [compiler] Add relocatable pointer constants for wasm memory references.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/verifier.cc

Issue 1759383003: [compiler] Add relocatable pointer constants for wasm memory references. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Removing additional check Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/verifier.cc

diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc

index f762c61157cdd2fb7bde33fc56116b6ee42fd79d..5793e3e1dcc4e4383bab67ccb7c32cc36cfebefa 100644

--- a/src/compiler/verifier.cc

+++ b/src/compiler/verifier.cc

@@ -345,6 +345,11 @@ void Verifier::Visitor::Check(Node* node) {

// Type is a number.

CheckUpperIs(node, Type::Number());

break;

+ case IrOpcode::kRelocatableInt32Constant:

+ case IrOpcode::kRelocatableInt64Constant:

+ // TODO(gdeepti): Add accurate checking for relocatable constants.

titzer 2016/03/23 20:35:36 You can probably drop this TODO. This looks fine t

gdeepti1 2016/03/31 22:29:54 Done.

+ CHECK_EQ(0, input_count);

+ break;

case IrOpcode::kHeapConstant:

// Constants have no inputs.

CHECK_EQ(0, input_count);

« no previous file with comments | « src/compiler/typer.cc ('k') | src/compiler/wasm-compiler.cc » ('j') | src/compiler/x64/instruction-selector-x64.cc » ('J')