Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Side by Side Diff: src/compiler/verifier.cc

Issue 1759383003: [compiler] Add relocatable pointer constants for wasm memory references. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Removing additional check Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 327 matching lines...) Expand 10 before | Expand all | Expand 10 after
338 CheckUpperIs(node, Type::Internal()); 338 CheckUpperIs(node, Type::Internal());
339 break; 339 break;
340 case IrOpcode::kFloat32Constant: 340 case IrOpcode::kFloat32Constant:
341 case IrOpcode::kFloat64Constant: 341 case IrOpcode::kFloat64Constant:
342 case IrOpcode::kNumberConstant: 342 case IrOpcode::kNumberConstant:
343 // Constants have no inputs. 343 // Constants have no inputs.
344 CHECK_EQ(0, input_count); 344 CHECK_EQ(0, input_count);
345 // Type is a number. 345 // Type is a number.
346 CheckUpperIs(node, Type::Number()); 346 CheckUpperIs(node, Type::Number());
347 break; 347 break;
348 case IrOpcode::kRelocatableInt32Constant:
349 case IrOpcode::kRelocatableInt64Constant:
350 // TODO(gdeepti): Add accurate checking for relocatable constants.
titzer 2016/03/23 20:35:36 You can probably drop this TODO. This looks fine t
gdeepti1 2016/03/31 22:29:54 Done.
351 CHECK_EQ(0, input_count);
352 break;
348 case IrOpcode::kHeapConstant: 353 case IrOpcode::kHeapConstant:
349 // Constants have no inputs. 354 // Constants have no inputs.
350 CHECK_EQ(0, input_count); 355 CHECK_EQ(0, input_count);
351 // Type can be anything represented as a heap pointer. 356 // Type can be anything represented as a heap pointer.
352 CheckUpperIs(node, Type::TaggedPointer()); 357 CheckUpperIs(node, Type::TaggedPointer());
353 break; 358 break;
354 case IrOpcode::kExternalConstant: 359 case IrOpcode::kExternalConstant:
355 // Constants have no inputs. 360 // Constants have no inputs.
356 CHECK_EQ(0, input_count); 361 CHECK_EQ(0, input_count);
357 // Type is considered internal. 362 // Type is considered internal.
(...skipping 921 matching lines...) Expand 10 before | Expand all | Expand 10 after
1279 replacement->op()->EffectOutputCount() > 0); 1284 replacement->op()->EffectOutputCount() > 0);
1280 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1285 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1281 replacement->opcode() == IrOpcode::kFrameState); 1286 replacement->opcode() == IrOpcode::kFrameState);
1282 } 1287 }
1283 1288
1284 #endif // DEBUG 1289 #endif // DEBUG
1285 1290
1286 } // namespace compiler 1291 } // namespace compiler
1287 } // namespace internal 1292 } // namespace internal
1288 } // namespace v8 1293 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698