Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issue 1759363002: Fixes list/map literal to not infer bottom (Closed)

Created:
4 years, 9 months ago by Jennifer Messerly
Modified:
4 years, 9 months ago
Reviewers:
Leaf, vsm
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 2 chunks +11 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
We could also fix inferring <Object>[1, 'hi'] if we wanted. Let me know, otherwise I'll ...
4 years, 9 months ago (2016-03-03 23:26:11 UTC) #2
Leaf
lgtm
4 years, 9 months ago (2016-03-04 00:53:28 UTC) #3
Jennifer Messerly
4 years, 9 months ago (2016-03-04 17:43:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
764a0678138b20547de64ac5c2f3ace5d747c89f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698