Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: pkg/analysis_server/lib/src/services/correction/fix_internal.dart

Issue 1759333002: Fix regression for import suggestions (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/analysis_abstract.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/correction/fix_internal.dart
diff --git a/pkg/analysis_server/lib/src/services/correction/fix_internal.dart b/pkg/analysis_server/lib/src/services/correction/fix_internal.dart
index a33d280fe75cd346087c593f82cef1cadc3ab2d0..7a3df8960b16a1379516c43e599072e4baccd119 100644
--- a/pkg/analysis_server/lib/src/services/correction/fix_internal.dart
+++ b/pkg/analysis_server/lib/src/services/correction/fix_internal.dart
@@ -1516,7 +1516,7 @@ class FixProcessor {
}
// prepare LibraryElement
LibraryElement libraryElement =
- context.getResult(librarySource, LIBRARY_ELEMENT8);
+ context.getResult(librarySource, LIBRARY_ELEMENT4);
scheglov 2016/03/09 19:05:32 Do you need LIBRARY_ELEMENT4 or LIBRARY_ELEMENT1 w
skybrian 2016/03/09 19:15:05 I don't know; LIBRARY_ELEMENT4 was based on your s
scheglov 2016/03/09 19:18:21 Well, ideally we need to use the lowest level.
skybrian 2016/03/09 19:33:47 This fix uses getExportNamespaceForLibrary() on th
scheglov 2016/03/09 19:36:07 OK, thank you for checking this.
if (libraryElement == null) {
continue;
}
« no previous file with comments | « no previous file | pkg/analysis_server/test/analysis_abstract.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698