Issue 1759303003: Change scripts to avoid generating things that bloat the compiled code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1759303003: Change scripts to avoid generating things that bloat the compiled code (Closed)

Created:
4 years, 9 months ago by Alan Knight

Modified:
4 years, 9 months ago

Reviewers:
terry, Jacob

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Change scripts to avoid generating things that bloat the compiled code BUG= Committed: https://github.com/dart-lang/sdk/commit/4f3abbd5efe870cd8fdf4413920ea12607d52760

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+162 lines, -255 lines)			Patch
M	sdk/lib/_blink/dartium/_blink_dartium.dart	View	4 chunks	+0 lines, -28 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	15 chunks	+43 lines, -136 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	8 chunks	+14 lines, -61 lines	0 comments	Download
M	sdk/lib/web_gl/dart2js/web_gl_dart2js.dart	View	1 chunk	+65 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/dartmetadata.py	View	4 chunks	+27 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_MessageEvent.darttemplate	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	tools/dom/templates/html/impl/impl_ServiceWorkerMessageEvent.darttemplate	View	2 chunks	+8 lines, -28 lines	0 comments	Download

Total messages: 4 (2 generated)

Alan Knight

There's one remaining issue with Notification.data, but that wasn't in Jacob's initial CL either. TBR

4 years, 9 months ago (2016-03-04 01:34:55 UTC) #2

Alan Knight

4 years, 9 months ago (2016-03-04 01:39:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4f3abbd5efe870cd8fdf4413920ea12607d52760 (presubmit successful).