Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 17593003: Fixed crash in about:policy on OS_ANDROID and OS_IOS. (Closed)

Created:
7 years, 6 months ago by Joao da Silva
Modified:
7 years, 6 months ago
CC:
chromium-reviews, anitawoodruff
Visibility:
Public.

Description

Fixed crash in about:policy on OS_ANDROID and OS_IOS. Those platforms don't have extensions/ code, and should have the extension policy code disabled. BUG=248533 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208236

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M chrome/browser/ui/webui/policy_ui.cc View 5 chunks +10 lines, -5 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Joao da Silva
@James: please review. Note that policy is still disabled by default on android and ios, ...
7 years, 6 months ago (2013-06-24 10:34:08 UTC) #1
anitawoodruff
Added similar ifdef guards on my CL at https://codereview.chromium.org/17387002/ https://codereview.chromium.org/17593003/diff/1/chrome/browser/ui/webui/policy_ui.cc File chrome/browser/ui/webui/policy_ui.cc (right): https://codereview.chromium.org/17593003/diff/1/chrome/browser/ui/webui/policy_ui.cc#newcode531 chrome/browser/ui/webui/policy_ui.cc:531: ...
7 years, 6 months ago (2013-06-24 11:53:52 UTC) #2
James Hawkins
LGTM but we need to figure out how to get rid of the ifdefs eventually.
7 years, 6 months ago (2013-06-24 14:52:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/17593003/1
7 years, 6 months ago (2013-06-24 15:00:07 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-24 17:55:19 UTC) #5
Message was sent while issue was closed.
Change committed as 208236

Powered by Google App Engine
This is Rietveld 408576698