Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Unified Diff: components/mus/public/interfaces/input_event_matcher.mojom

Issue 1759273002: Add AcceleratorType to EventMatcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/mus/public/interfaces/input_event_matcher.mojom
diff --git a/components/mus/public/interfaces/input_event_matcher.mojom b/components/mus/public/interfaces/input_event_matcher.mojom
index 3e0929da2dd4fbc4d092afff750fa1be4501eba5..4ef206daeb8600ef3e3cabf35c2c265674b96c1d 100644
--- a/components/mus/public/interfaces/input_event_matcher.mojom
+++ b/components/mus/public/interfaces/input_event_matcher.mojom
@@ -8,6 +8,11 @@ import "components/mus/public/interfaces/input_event_constants.mojom";
import "components/mus/public/interfaces/input_key_codes.mojom";
import "ui/mojo/geometry/geometry.mojom";
+
+struct AcceleratorTypeMatcher {
sky 2016/03/03 23:41:24 type->phase
jonross 2016/03/04 15:26:37 Done.
+ AcceleratorType accelerator_type;
+};
+
struct KeyEventMatcher {
KeyboardCode keyboard_code;
};
@@ -42,6 +47,7 @@ struct EventFlagsMatcher {
// A matcher to match any key-press event would be:
// - |type_matcher.type| = mus::mojom::EventType::KEY_PRESSED
struct EventMatcher {
+ AcceleratorTypeMatcher? accelerator_matcher;
sky 2016/03/03 23:41:24 Shouldn't this be required? What would it mean if
jonross 2016/03/04 15:26:37 I had been setting up a default of pre-target, but
EventTypeMatcher? type_matcher;
EventFlagsMatcher? flags_matcher;
// These flags will be stripped from incoming events' flags when comparing

Powered by Google App Engine
This is Rietveld 408576698